From: Thierry Reding <thierry.reding@kernel.org>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2] dt-bindings: net: nvidia,tegra234-mgbe: Add missing properties
Date: Wed, 2 Sep 2026 02:30:04 +0200 [thread overview]
Message-ID: <20260902003004.453960-1-thierry.reding@kernel.org> (raw)
From: Thierry Reding <treding@nvidia.com>
Being a DWMAC derivative, the Tegra234 MGBE supports AXI configuration
nodes named stmmac-axi-config and phandle references to them using the
snps,axi-config property.
While at it, add the 10gbase-r PHY mode.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
Changes in v2:
- move common properties to snps,dwmac-common.yaml
- link to v1: https://lore.kernel.org/linux-tegra/20260716212001.989872-1-thierry.reding@kernel.org/
.../bindings/net/nvidia,tegra234-mgbe.yaml | 8 ++-
.../bindings/net/snps,dwmac-common.yaml | 66 +++++++++++++++++++
.../devicetree/bindings/net/snps,dwmac.yaml | 52 +--------------
3 files changed, 73 insertions(+), 53 deletions(-)
create mode 100644 Documentation/devicetree/bindings/net/snps,dwmac-common.yaml
diff --git a/Documentation/devicetree/bindings/net/nvidia,tegra234-mgbe.yaml b/Documentation/devicetree/bindings/net/nvidia,tegra234-mgbe.yaml
index 215f14d1897d2..48e4798a039b0 100644
--- a/Documentation/devicetree/bindings/net/nvidia,tegra234-mgbe.yaml
+++ b/Documentation/devicetree/bindings/net/nvidia,tegra234-mgbe.yaml
@@ -81,8 +81,9 @@ properties:
phy-mode:
contains:
enum:
- - usxgmii
- 10gbase-kr
+ - 10gbase-r
+ - usxgmii
mdio:
$ref: mdio.yaml#
@@ -90,6 +91,9 @@ properties:
description:
Optional node for embedded MDIO controller.
+allOf:
+ - $ref: snps,dwmac-common.yaml#
+
required:
- compatible
- reg
@@ -103,7 +107,7 @@ required:
- phy-handle
- phy-mode
-additionalProperties: false
+unevaluatedProperties: false
examples:
- |
diff --git a/Documentation/devicetree/bindings/net/snps,dwmac-common.yaml b/Documentation/devicetree/bindings/net/snps,dwmac-common.yaml
new file mode 100644
index 0000000000000..a38ff314b3cd1
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/snps,dwmac-common.yaml
@@ -0,0 +1,66 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/snps,dwmac-common.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Synopsys DesignWare MAC common properties
+
+maintainers:
+ - Alexandre Torgue <alexandre.torgue@foss.st.com>
+ - Giuseppe Cavallaro <peppe.cavallaro@st.com>
+ - Jose Abreu <joabreu@synopsys.com>
+
+properties:
+ stmmac-axi-config:
+ type: object
+ unevaluatedProperties: false
+ description:
+ AXI BUS Mode parameters.
+
+ properties:
+ snps,lpi_en:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description:
+ enable Low Power Interface
+
+ snps,xit_frm:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description:
+ unlock on WoL
+
+ snps,wr_osr_lmt:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description:
+ max write outstanding req. limit
+
+ snps,rd_osr_lmt:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description:
+ max read outstanding req. limit
+
+ snps,blen:
+ $ref: /schemas/types.yaml#/definitions/uint32-array
+ description:
+ this is a vector of supported burst length.
+ minItems: 7
+ maxItems: 7
+
+ snps,fb:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description:
+ fixed-burst
+
+ snps,axi-config:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description:
+ AXI BUS Mode parameters. Phandle to a node that can contain the
+ following properties
+ * snps,lpi_en, enable Low Power Interface
+ * snps,xit_frm, unlock on WoL
+ * snps,wr_osr_lmt, max write outstanding req. limit
+ * snps,rd_osr_lmt, max read outstanding req. limit
+ * snps,blen, this is a vector of supported burst length.
+ * snps,fb, fixed-burst
+
+additionalProperties: true
diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
index 2449311c6d28e..c5222c82e27a9 100644
--- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
@@ -195,18 +195,6 @@ properties:
can be passive (no SW requirement), and requires that the MAC operate
in a different mode than the PHY in order to function.
- snps,axi-config:
- $ref: /schemas/types.yaml#/definitions/phandle
- description:
- AXI BUS Mode parameters. Phandle to a node that can contain the
- following properties
- * snps,lpi_en, enable Low Power Interface
- * snps,xit_frm, unlock on WoL
- * snps,wr_osr_lmt, max write outstanding req. limit
- * snps,rd_osr_lmt, max read outstanding req. limit
- * snps,blen, this is a vector of supported burst length.
- * snps,fb, fixed-burst
-
snps,mtl-rx-config:
$ref: /schemas/types.yaml#/definitions/phandle
description:
@@ -558,45 +546,6 @@ properties:
required:
- compatible
- stmmac-axi-config:
- type: object
- unevaluatedProperties: false
- description:
- AXI BUS Mode parameters.
-
- properties:
- snps,lpi_en:
- $ref: /schemas/types.yaml#/definitions/flag
- description:
- enable Low Power Interface
-
- snps,xit_frm:
- $ref: /schemas/types.yaml#/definitions/flag
- description:
- unlock on WoL
-
- snps,wr_osr_lmt:
- $ref: /schemas/types.yaml#/definitions/uint32
- description:
- max write outstanding req. limit
-
- snps,rd_osr_lmt:
- $ref: /schemas/types.yaml#/definitions/uint32
- description:
- max read outstanding req. limit
-
- snps,blen:
- $ref: /schemas/types.yaml#/definitions/uint32-array
- description:
- this is a vector of supported burst length.
- minItems: 7
- maxItems: 7
-
- snps,fb:
- $ref: /schemas/types.yaml#/definitions/flag
- description:
- fixed-burst
-
required:
- compatible
- reg
@@ -610,6 +559,7 @@ dependencies:
allOf:
- $ref: ethernet-controller.yaml#
+ - $ref: snps,dwmac-common.yaml#
- if:
properties:
compatible:
--
2.55.0
next reply other threads:[~2026-09-02 0:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 0:30 Thierry Reding [this message]
2026-09-10 10:53 ` [PATCH v2] dt-bindings: net: nvidia,tegra234-mgbe: Add missing properties Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260902003004.453960-1-thierry.reding@kernel.org \
--to=thierry.reding@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.