From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98B0F35B63F for ; Wed, 2 Sep 2026 01:57:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788314242; cv=none; b=bcpaHlrPI3AUSlPIgVZFOov0viDL0NpQmO3e613YZrzBTif0R2nXkIJJvQkLCBmc/o9k2QuTv67L1SllwjRjUfZtqVcwN7E8ZrrJcwP8/1RSpAuV3VAvQJg5sXiDasEHa0OHS3l7X8FivirjL78EUL3JEi2RWSOW8jsWFiXUCCs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788314242; c=relaxed/simple; bh=kjynEym4JkM4qLFWRtB6GBT9eT/13ERJsjb/5ssDOQI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eo4plkNpTojnsUF0asU9F7GQ5oiPkQ4N9DRIjjsdA8iyuYDXrNaV02du+EzJ20xuogttYZE3SUKb+zl2FyzzFZ+A4Q5ohz7ElNfZqsDhaSX4IAjbKg92IaZ8nhTQ6abZ8z4W4CJzxuVODxBCQaEz15nA2eMcJl1oqhrDT+pLL9s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b=neuNbo44; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20251104.gappssmtp.com header.i=@dama-to.20251104.gappssmtp.com header.b="neuNbo44" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-38511175ad3so518337a91.2 for ; Tue, 01 Sep 2026 18:57:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20251104.gappssmtp.com; s=20251104; t=1788314234; x=1788919034; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+2ASlAu8y5yvnOMRkejZNi7wm/1MZgn7xMNUrYUfQtI=; b=neuNbo44bMNUajm357LiSzKnzPxriyzf3VQtr1yrdq5+8LYsxqaz7V9REmNxf03Xkz OHqxnbS1CLxomdb//e+Rs7Ip/1t5n3qYfwLabG0J/oHZSxQhf1uWerbrPTeFUBesMSli Kd5K+xcf04yV/xtMzdqBewpFFDfc4CHUdMCKPD0ekp1XeUfj4m3RAqsiTsIp2bJECUsa GgFcTT/CNo9O/CZrUPUCmF7Hp1o0bNx5puZ7SgxfXADOFBMzbI9Hw4m5WIk6+Q/niJhC 8ml3F+oYNfBZqvq2TzgCh3CpE+QNttvN5llDk9yBO6OF2hQ1VmJ2pGZSizNkwtRSZwZf s4SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788314234; x=1788919034; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=+2ASlAu8y5yvnOMRkejZNi7wm/1MZgn7xMNUrYUfQtI=; b=kwTrdoqggKgAxKoi29S1wvbb8QLUfUrXSbFi+ipWweab7xnJLO662euVW9agksFz7X BrE6ECnWHt/8PhAsTrM4fxfO50a0bG44wm1eA0gWKdbcqVCUzYpcdcKvMGgoQlK4YQwu brxoYSX60z8yYMvB24e60o+8ILOrtLOw2oBAHeQ80Rm5YhG7Lcic7cdIX0Gk9xc5459c 3R7C3ybZIRLlqrvaZATAODXeP5VJnia/i8ZNQsqbwbYPW16HRdFSAms+Wo0Zg0hFsfGb BNJoASQD86Vd1SmS8e7B2gXt6ETb3si/xuTD8pW6nJQH5qbVKkO+9FsulNeqXcamXH1S nhWg== X-Gm-Message-State: AFuF++k0ex0AqCK5180UQPj0fDEb5VX5NtlT7DpqLazKM2u9/QuBkhjZ t+FwT7CG1YPMPRCHBynvisZ5hVDrHocRfk88VRIzpjHp11lRbnDgYiSVP7gJFbfbuDA61sMzKw7 cVa86L3Y= X-Gm-Gg: AYBFou19L+/fNkIfNC1YR+Dlkknu7FRruwckUnPs89t+KJPH7eq3zqguz0spyvjryOY 8H/VOItIkmss4PEIBhSIKi86IbtA0M8frezwVKbT/6kSwsOOOYhf+B2tZ4BlcicNj2cA1sq7U6p DjyBQYY76z5+jAnPDGV1EZV2R2iFDSUYnvxcBwUB6QO31pVjhDbMT66xNqtL/oAatHAkltL6x5a TZVM2P1afvZYBJjzapUr0cF7xp69o7zrlP+aCowQqiYMHD+frMptmZfx2HNH09AFnVH5QuuiCmx QUzkKi2NM52d5E4ZQU/FFV3pgDS8BguZon4o1Fr00/kbsOAE6Ao2xEIk0CBXJZQPrFTaT7WD9Bf fEetF2uBg5z33hLdHaw2pc+5PqXXQoHEsgl5WG33EFpZYb63eT1Db3dZMBACCpi8jEJhfXwVnMQ qTmI2VKqqo5iRwjjtViwwcVeJ3hoXP5jrRWYmPwRwin1wbY3ZQM0cN X-Received: by 2002:a17:90b:4c52:b0:38e:6aa7:68ad with SMTP id 98e67ed59e1d1-39aedf7c6aemr1801505a91.5.1788314233810; Tue, 01 Sep 2026 18:57:13 -0700 (PDT) Received: from localhost ([2a03:2880:2ff:5a::]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39ae380d7a9sm2252710a91.12.2026.09.01.18.57.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2026 18:57:13 -0700 (PDT) From: Joe Damato To: netdev@vger.kernel.org, Michael Chan , Pavan Chebbi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Somnath Kotur Cc: horms@kernel.org, kalesh-anakkur.purayil@broadcom.com, colin.winegarden@broadcom.com, rukhsana.ansari@broadcom.com, linux-kernel@vger.kernel.org, raphaelcf@meta.com, Joe Damato , Sashiko , stable@vger.kernel.org Subject: [PATCH net v5 1/6] bnxt_en: Only restore LRO if the device supports TPA Date: Tue, 1 Sep 2026 18:56:44 -0700 Message-ID: <20260902015652.2421609-2-joe@dama.to> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260902015652.2421609-1-joe@dama.to> References: <20260902015652.2421609-1-joe@dama.to> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit With a P5+ device with firmware that reports max_aggs_supported == 0, it is possible to make LRO settable by attaching and detaching an XDP program even though the device does not support TPA. Fix this by testing BNXT_SUPPORTS_TPA before restoring the feature bit. Fixes: f0aa6a37a3db ("eth: bnxt: always recalculate features after XDP clearing, fix null-deref") Reported-by: Sashiko Link: https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260828190900.1767611-1-joe%40dama.to Cc: stable@vger.kernel.org Signed-off-by: Joe Damato --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index d59bcca73a2b..0e5c2a48f313 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -5006,7 +5006,8 @@ void bnxt_set_rx_skb_mode(struct bnxt *bp, bool page_mode) bnxt_get_max_rings(bp, &rx, &tx, true); if (rx > 1) { bp->flags &= ~BNXT_FLAG_NO_AGG_RINGS; - bp->dev->hw_features |= NETIF_F_LRO; + if (BNXT_SUPPORTS_TPA(bp)) + bp->dev->hw_features |= NETIF_F_LRO; } } -- 2.53.0-Meta