From: sashiko-bot@kernel.org
To: "longlong yan" <yanlonglong@kylinos.cn>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf bench numa: add NULL check after calloc()
Date: Wed, 02 Sep 2026 07:15:21 +0000 [thread overview]
Message-ID: <20260902071521.757041F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260902070913.1424-1-yanlonglong@kylinos.cn>
> Two calloc() calls in the numa benchmark lack NULL return checks,
> leading to potential NULL pointer dereferences on allocation failure:
>
> 1. worker_process(): the allocated `pthreads` array is used in the
> following for-loop via pthreads[t] without checking for NULL.
>
> 2. __bench_numa(): the allocated `pids` array is used in the following
> for-loop via pids[i] without checking for NULL.
>
> Add BUG_ON() checks after each calloc(), consistent with the existing
> NULL check style used elsewhere in the same file (e.g., node_present
> and nodes allocations).
>
> Signed-off-by: longlong yan <yanlonglong@kylinos.cn>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260902070913.1424-1-yanlonglong@kylinos.cn?part=1
prev parent reply other threads:[~2026-09-02 7:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 7:09 [PATCH] perf bench numa: add NULL check after calloc() longlong yan
2026-09-02 7:15 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260902071521.757041F00A3A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=yanlonglong@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.