From: sashiko-bot@kernel.org
To: "Jinjie Ruan" <ruanjinjie@huawei.com>
Cc: tytso@mit.edu, linux-ext4@vger.kernel.org
Subject: Re: [PATCH v3 4/8] fs: Use acquire/release for fdtable resize synchronization
Date: Wed, 02 Sep 2026 07:53:56 +0000 [thread overview]
Message-ID: <20260902075357.591081F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260902074805.398540-5-ruanjinjie@huawei.com>
> Replace the smp_wmb()/smp_rmb() barrier pair with
> smp_store_release()/smp_load_acquire() on `files->resize_in_progress`.
> The flag is the publish point for fdtable expansion: writers clear it
> via release after rcu_assign_pointer(), readers check it via acquire
> before rcu_dereference_sched(). Observing it clear guarantees the new
> fdt pointer is visible.
>
> This expresses the pattern more clearly and allows cheaper one-way
> barriers on weakly-ordered architectures (e.g. arm64 STLR/LDAR vs
> DMB ISHST/ISHLD).
>
> Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> Cc: Christian Brauner <brauner@kernel.org>
> Cc: Jan Kara <jack@suse.cz>
> Reviewed-by: Jan Kara <jack@suse.cz>
> Assisted-by: DeepSeek:DeepSeek-V3
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260902074805.398540-1-ruanjinjie@huawei.com?part=4
next prev parent reply other threads:[~2026-09-02 7:53 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 7:47 [PATCH v3 0/8] Convert barrier pairs to acquire/release for better performance Jinjie Ruan
2026-09-02 7:47 ` [PATCH v3 1/8] user_namespace: Use acquire/release for nr_extents synchronization Jinjie Ruan
2026-09-02 7:53 ` sashiko-bot
2026-09-02 10:09 ` Bradley Morgan
2026-09-02 13:03 ` Andy Shevchenko
2026-09-02 13:04 ` Andy Shevchenko
2026-09-03 1:42 ` Jinjie Ruan
2026-09-03 2:16 ` Jinjie Ruan
2026-09-02 7:47 ` [PATCH v3 2/8] lib/vsprintf: Use acquire/release for ptr_key publication Jinjie Ruan
2026-09-02 7:52 ` sashiko-bot
2026-09-04 13:13 ` Petr Mladek
2026-09-02 7:48 ` [PATCH v3 3/8] fs: aio: Use acquire/release for ring->tail publication Jinjie Ruan
2026-09-02 7:57 ` sashiko-bot
2026-09-02 7:48 ` [PATCH v3 4/8] fs: Use acquire/release for fdtable resize synchronization Jinjie Ruan
2026-09-02 7:53 ` sashiko-bot [this message]
2026-09-02 7:48 ` [PATCH v3 5/8] pidfs: Use test_bit_acquire() for attr flag tests Jinjie Ruan
2026-09-02 7:55 ` sashiko-bot
2026-09-02 7:48 ` [PATCH v3 6/8] super: Use acquire for SB_BORN check in super_cache_count() Jinjie Ruan
2026-09-02 7:58 ` sashiko-bot
2026-09-02 7:48 ` [PATCH v3 7/8] ext4: Fix out-of-bounds read in ext4_get_group_info() Jinjie Ruan
2026-09-02 8:01 ` sashiko-bot
2026-09-02 7:48 ` [PATCH v3 8/8] ext4: Convert group-count barrier protocol to acquire/release Jinjie Ruan
2026-09-02 7:58 ` sashiko-bot
2026-09-02 14:19 ` [PATCH v3 0/8] Convert barrier pairs to acquire/release for better performance Theodore Tso
2026-09-02 14:56 ` Jan Kara
2026-09-04 7:20 ` Jinjie Ruan
2026-09-04 12:28 ` Petr Mladek
2026-09-04 12:28 ` Petr Mladek
2026-09-07 11:29 ` Jinjie Ruan
2026-09-07 11:29 ` Jinjie Ruan
2026-09-07 12:59 ` David Laight
2026-09-07 12:59 ` David Laight
2026-09-09 7:11 ` Jinjie Ruan
2026-09-09 7:11 ` Jinjie Ruan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260902075357.591081F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=ruanjinjie@huawei.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.