All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Serhat Kumral <serhatkumral1@gmail.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>, Parav Pandit <parav@nvidia.com>,
	linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RDMA/core: Fix use-after-free when netns exit races compat dev removal
Date: Wed, 2 Sep 2026 10:56:53 +0300	[thread overview]
Message-ID: <20260902075653.GS24140@unreal> (raw)
In-Reply-To: <20260818080920.13555-1-serhatkumral1@gmail.com>

On Tue, Aug 18, 2026 at 11:09:20AM +0300, Serhat Kumral wrote:
> A compat device is removed from two places: disable_device() during the
> ib device unregistration, and rdma_dev_exit_net() when the netns it
> belongs to dies. remove_one_compat_dev() lets the xa_erase() decide
> which of the two performs the removal, but drops compat_devs_mutex
> before device_del(), so the caller that finds nothing to erase returns
> without waiting for the removal the other one is running.
> 
> When that caller is rdma_dev_exit_net(), cleanup_net() carries on while
> the compat device is still alive. Its kobject is tagged with the dying
> net, so the device_del() still in progress dereferences net->uevent_sock
> after uevent_net_exit() has freed it:
> 
>  CPU0 (ib-unreg-wq)                CPU1 (netns wq)
>  ------------------                ---------------
>  __ib_unregister_device()
>    disable_device()
>      remove_compat_devs()
>        remove_one_compat_dev()
>          xa_erase()
>          device_del(cdev)
>          ...
>                                    cleanup_net()
>                                      rdma_dev_exit_net()
>                                        remove_one_compat_dev()
>                                          xa_erase()
>                                        // returns without waiting
>                                      uevent_net_exit()
>                                        kfree(net->uevent_sock)
>          kobject_uevent_env()
>            net->uevent_sock->sk    // UAF
> 
>   BUG: KASAN: slab-use-after-free in kobject_uevent_env+0xb6f/0xc80
>   Read of size 8 at addr ffff888103806490 by task kworker/u16:1/41
>   Workqueue: ib-unreg-wq ib_unregister_work
>   Call Trace:
>    kobject_uevent_env+0xb6f/0xc80
>    device_del+0x737/0xc10
>    disable_device+0x1ad/0x230
>    __ib_unregister_device+0x229/0x3f0
>   Freed by task 12:
>    kfree+0x1b3/0x550
>    ops_undo_list+0x273/0x8c0
>    cleanup_net+0x3b3/0x720

Please don't trim kernel panic logs. Please post the full output,
including the steps required to reproduce the issue.

Thanks

> 
> Fix by holding compat_devs_mutex across the whole removal, so that once
> remove_one_compat_dev() returns the compat device is gone no matter
> which caller removed it.
> 
> Fixes: 4e0f7b907072 ("RDMA/core: Implement compat device/sysfs tree in net namespace")
> Assisted-by: Claude:claude-opus-5
> Signed-off-by: Serhat Kumral <serhatkumral1@gmail.com>
> ---
> With this patch applied the report no longer shows up.
> 
>  drivers/infiniband/core/device.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
> index d954eda63134..a80ac69ef986 100644
> --- a/drivers/infiniband/core/device.c
> +++ b/drivers/infiniband/core/device.c
> @@ -1005,14 +1005,20 @@ static void remove_one_compat_dev(struct ib_device *device, u32 id)
>  {
>  	struct ib_core_device *cdev;
>  
> +	/*
> +	 * Hold the lock across device_del(): the other remover may have won
> +	 * the xa_erase() and still be inside device_del(), and the netns exit
> +	 * path has to wait for it instead of letting cleanup_net() free the
> +	 * netns state the compat device is still tagged with.
> +	 */
>  	mutex_lock(&device->compat_devs_mutex);
>  	cdev = xa_erase(&device->compat_devs, id);
> -	mutex_unlock(&device->compat_devs_mutex);
>  	if (cdev) {
>  		ib_free_port_attrs(cdev);
>  		device_del(&cdev->dev);
>  		put_device(&cdev->dev);
>  	}
> +	mutex_unlock(&device->compat_devs_mutex);
>  }
>  
>  static void remove_compat_devs(struct ib_device *device)
> -- 
> 2.53.0
> 

  reply	other threads:[~2026-09-02  7:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-18  8:09 [PATCH] RDMA/core: Fix use-after-free when netns exit races compat dev removal Serhat Kumral
2026-09-02  7:56 ` Leon Romanovsky [this message]
2026-09-03  9:46   ` Serhat Kumral

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260902075653.GS24140@unreal \
    --to=leon@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=parav@nvidia.com \
    --cc=serhatkumral1@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.