All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cezary Rojewski <cezary.rojewski@intel.com>
To: broonie@kernel.org
Cc: tiwai@suse.com, perex@perex.cz, amade@asmblr.net,
	linux-sound@vger.kernel.org,
	Cezary Rojewski <cezary.rojewski@intel.com>
Subject: [PATCH v4 02/10] ALSA: hda: ext: Clean up streams if their initialization fails
Date: Wed,  2 Sep 2026 10:18:06 +0200	[thread overview]
Message-ID: <20260902081814.1590883-3-cezary.rojewski@intel.com> (raw)
In-Reply-To: <20260902081814.1590883-1-cezary.rojewski@intel.com>

snd_hdac_ext_stream_init_all() does not rollback changes done when
the allocation fails. Fix that to simplify its usage.

Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
---
 sound/hda/core/ext/stream.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/sound/hda/core/ext/stream.c b/sound/hda/core/ext/stream.c
index 517bd151fcc3..1f96e0484660 100644
--- a/sound/hda/core/ext/stream.c
+++ b/sound/hda/core/ext/stream.c
@@ -102,8 +102,10 @@ int snd_hdac_ext_stream_init_all(struct hdac_bus *bus, int start_idx,
 
 	for (i = 0; i < num_stream; i++) {
 		struct hdac_ext_stream *hext_stream = kzalloc_obj(*hext_stream);
-		if (!hext_stream)
+		if (!hext_stream) {
+			snd_hdac_ext_stream_free_all(bus);
 			return -ENOMEM;
+		}
 		tag = ++stream_tag;
 		snd_hdac_ext_stream_init(bus, hext_stream, idx, dir, tag);
 		idx++;
@@ -111,7 +113,6 @@ int snd_hdac_ext_stream_init_all(struct hdac_bus *bus, int start_idx,
 	}
 
 	return 0;
-
 }
 EXPORT_SYMBOL_GPL(snd_hdac_ext_stream_init_all);
 
-- 
2.34.1


  parent reply	other threads:[~2026-09-02  8:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-02  8:18 [PATCH v4 00/10] ALSA/ASoC: Intel: avs: HDAudio bus and general fixes Cezary Rojewski
2026-09-02  8:18 ` [PATCH v4 01/10] ALSA: hda: ext: Clean up links if their initialization fails Cezary Rojewski
2026-09-02 13:43   ` Takashi Iwai
2026-09-02  8:18 ` Cezary Rojewski [this message]
2026-09-02 13:43   ` [PATCH v4 02/10] ALSA: hda: ext: Clean up streams " Takashi Iwai
2026-09-02  8:18 ` [PATCH v4 03/10] ASoC: Intel: avs: Clean up the bus when its " Cezary Rojewski
2026-09-02  8:18 ` [PATCH v4 04/10] ASoC: Intel: avs: Clean up the bus when fetching ML caps fails Cezary Rojewski
2026-09-02  8:18 ` [PATCH v4 05/10] ASoC: Intel: avs: Clean up streams if their initialization fails Cezary Rojewski
2026-09-02  8:18 ` [PATCH v4 06/10] ASoC: Intel: avs: Do not ignore -ENOENT when loading a topology Cezary Rojewski
2026-09-02  8:18 ` [PATCH v4 07/10] ASoC: Intel: avs: Cancel d0ix_work asynchrounously during recovery Cezary Rojewski
2026-09-02  8:18 ` [PATCH v4 08/10] ASoC: Intel: avs: Fix unbalanced module reference count Cezary Rojewski
2026-09-02  8:18 ` [PATCH v4 09/10] ASoC: Intel: avs: Refactor and fix init_config access Cezary Rojewski
2026-09-02  8:18 ` [PATCH v4 10/10] ASoC: Intel: avs: hda: Constrain MSBs on startup Cezary Rojewski
2026-09-03 21:53 ` [PATCH v4 00/10] ALSA/ASoC: Intel: avs: HDAudio bus and general fixes Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260902081814.1590883-3-cezary.rojewski@intel.com \
    --to=cezary.rojewski@intel.com \
    --cc=amade@asmblr.net \
    --cc=broonie@kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.