Re: [PATCH 1/8] ARM: tegra: Clean up AHUB on Tegra124

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The child bus address in the 'ranges' property of the ahub node is missing a trailing zero, breaking address translation for all I2S/AHUB child nodes.
--

commit 801981d1969d9fdac375d63ff0a71f218d782d11
Author: Thierry Reding <treding@nvidia.com>

ARM: tegra: Clean up AHUB on Tegra124

This commit updates the #address-cells and #size-cells properties to <1> 
for the AHUB on Tegra124, since 64-bit addressing is unnecessary for this 
hardware. It also adjusts the ranges property to encompass the entire AHUB 
range according to the TRM.

> diff --git a/arch/arm/boot/dts/nvidia/tegra124.dtsi b/arch/arm/boot/dts/nvidia/tegra124.dtsi
> index ce4efa1de509b..7a71dba42dc0c 100644
> --- a/arch/arm/boot/dts/nvidia/tegra124.dtsi
> +++ b/arch/arm/boot/dts/nvidia/tegra124.dtsi
> @@ -1114,13 +1114,13 @@ ahub@70300000 {
[ ... ]
> -		ranges;
> -		#address-cells = <2>;
> -		#size-cells = <2>;
> +		ranges = <0x7030000 0x0 0x70300000 0x10000>;

[Severity: High]
Does this child bus address miss a trailing zero? The ranges property here 
specifies a child base address of 0x7030000, but it looks like it should 
be 0x70300000 to match the ahub node address and the subsequent child 
device addresses.

If the child base address is set to 0x7030000, wouldn't the translation map 
fail to cover child nodes starting at 0x70301000 (such as tegra_i2s0)? This 
appears to cause all I2S and other audio devices under the AHUB to fail to 
probe unconditionally on boot, since the OF core cannot translate their 
memory addresses properly.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260902-tegra-ahub-dt-cleanup-v1-0-028f3c5e72f6@nvidia.com?part=1