From: Andreas Kemnade <andreas@kemnade.info>
To: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
Cc: "Tero Kristo" <kristo@kernel.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Brian Masney" <bmasney@redhat.com>,
"Tony Lindgren" <tony@atomide.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Théo Lebrun" <theo.lebrun@bootlin.com>,
"Grégory Clement" <gregory.clement@bootlin.com>,
linux-omap@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, hns@goldecilo.com
Subject: Re: [PATCH v2 0/2] clk: ti: mux: resolve parent clocks by DT index, not by name
Date: Wed, 2 Sep 2026 10:34:25 +0200 [thread overview]
Message-ID: <20260902103425.2cf41f15@kemnade.info> (raw)
In-Reply-To: <20260902082639.69643254@kemnade.info>
On Wed, 2 Sep 2026 08:26:39 +0200
Andreas Kemnade <andreas@kemnade.info> wrote:
> Hi,
>
> this seems to produce on OMAP3 (DM3730), even with the init fix.
>
> [ 0.000000] clocksource: 32k_counter: mask: 0xffffffff max_cycles: 0xffffffff
> , max_idle_ns: 58327039986419 ns
> [ 0.000030] sched_clock: 32 bits at 33kHz, resolution 30517ns, wraps every 65
> 535999984741ns
> [ 0.013488] clk: failed to reparent gpt1_fck to omap_32k_fck: -22
> [ 0.019805] Failed to initialize '/ocp@68000000/target-module@48318000/timer@
> 0': -19
>
created a backrace with that -EINVAL:
[ 0.030975] clk_fetch_parent_index from clk_core_set_parent_nolock+0x7c/0x18
[ 0.031005] clk_core_set_parent_nolock from clk_set_parent+0x6c/0x18c
[ 0.031036] clk_set_parent from of_clk_set_defaults+0x304/0x6e8
[ 0.031066] of_clk_set_defaults from dmtimer_systimer_setup+0x5c/0x1cc
[ 0.031127] dmtimer_systimer_setup from dmtimer_clkevt_init_common+0x78/0x10
[ 0.031158] dmtimer_clkevt_init_common from dmtimer_clockevent_init+0x80/0x8
[ 0.031188] dmtimer_clockevent_init from dmtimer_systimer_init+0x114/0x134
[ 0.031219] dmtimer_systimer_init from timer_probe+0x68/0xf4
[ 0.031250] timer_probe from start_kernel+0x19c/0x370
[ 0.031280] start_kernel from 0x0
Maybe something is not ready yet for using indexes instead of names there.
> Regards,
> Andreas
>
> On Mon, 27 Jul 2026 09:41:39 +0200
> Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com> wrote:
>
> > This commit aims to solve an issue I've been describing a few months ago
> > on AM335x SoC [1]. I believe using the parent_data field of
> > clk_init_data structure is now the preferred way to convey that data,
> > and it should be more reliable than string comparisons.
> >
> > [1]: https://lore.kernel.org/all/DI4RUFQNSSNP.2QMSSQWJW9I2O@bootlin.com/
> >
> > Signed-off-by: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
> > ---
> > Changes in v2:
> > - Also use clk_parent_data structure in composite.c.
> > - Rebase on v7.2-rc5.
> > - Link to v1: https://lore.kernel.org/r/20260715-mathieu-wdt-clock-theo-v1-1-da65bba1828b@bootlin.com
> >
> > ---
> > Mathieu Dubois-Briand (2):
> > clk: ti: mux: resolve parent clocks by DT index, not by name
> > clk: ti: composite: resolve parent clocks by DT index, not by name
> >
> > drivers/clk/ti/composite.c | 26 ++++++++++++++------------
> > drivers/clk/ti/mux.c | 20 +++++++++++---------
> > 2 files changed, 25 insertions(+), 21 deletions(-)
> > ---
> > base-commit: f5098b6bae761e346ebcd9da7f95622c04733cff
> > change-id: 20260713-mathieu-wdt-clock-theo-f0c5ba58e258
> >
> > Best regards,
>
>
>
prev parent reply other threads:[~2026-09-02 8:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 7:41 [PATCH v2 0/2] clk: ti: mux: resolve parent clocks by DT index, not by name Mathieu Dubois-Briand
2026-07-27 7:41 ` [PATCH v2 1/2] " Mathieu Dubois-Briand
2026-07-28 14:11 ` Brian Masney
2026-08-14 5:43 ` Stephen Boyd
2026-08-18 16:02 ` Geert Uytterhoeven
2026-08-18 21:13 ` Brian Masney
2026-08-19 5:39 ` Mathieu Dubois-Briand
2026-08-19 12:32 ` Geert Uytterhoeven
2026-08-19 15:12 ` Mathieu Dubois-Briand
2026-08-19 19:13 ` Geert Uytterhoeven
2026-08-19 21:25 ` Brian Masney
2026-07-27 7:41 ` [PATCH v2 2/2] clk: ti: composite: " Mathieu Dubois-Briand
2026-07-28 14:11 ` Brian Masney
2026-08-14 5:43 ` Stephen Boyd
2026-09-02 6:26 ` [PATCH v2 0/2] clk: ti: mux: " Andreas Kemnade
2026-09-02 8:30 ` Mathieu Dubois-Briand
2026-09-02 9:15 ` Andreas Kemnade
2026-09-02 22:26 ` Andreas Kemnade
2026-09-03 9:53 ` Andreas Kemnade
2026-09-04 7:50 ` Mathieu Dubois-Briand
2026-09-04 13:41 ` Andreas Kemnade
2026-09-02 8:34 ` Andreas Kemnade [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260902103425.2cf41f15@kemnade.info \
--to=andreas@kemnade.info \
--cc=bmasney@redhat.com \
--cc=gregory.clement@bootlin.com \
--cc=hns@goldecilo.com \
--cc=kristo@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mathieu.dubois-briand@bootlin.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=theo.lebrun@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.