Re: [PATCH 2/3] arm64: dts: mediatek: mt8395-genio-1200-evk-ufs: Complete UFS power supplies

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch introduces undocumented device tree properties (`avdd12-supply`, `avdd12-ckbuf-supply`, `avdd18-supply`) which are neither defined in the DT bindings nor parsed by the driver.
--

commit b5065cb681ea986f66b5cbd4f119cd47dc276eab
Author: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>

arm64: dts: mediatek: mt8395-genio-1200-evk-ufs: Complete UFS power supplies

This commit adds regulators used to power the MT8395 UFS controller to the
Genio 1200-EVK board devicetree.

> diff --git a/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk-ufs.dts b/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk-ufs.dts
> index e09a3ecd87730..f3d839f319187 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk-ufs.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt8395-genio-1200-evk-ufs.dts
> @@ -16,6 +16,9 @@ / {
>  
>  &ufshci {
>  	status = "okay";
> +	avdd12-supply = <&mt6359_vrf12_ldo_reg>;
> +	avdd12-ckbuf-supply = <&mt6359_vbbck_ldo_reg>;
> +	avdd18-supply = <&mt6359_vio18_ldo_reg>;

[Severity: Medium]
Will these new properties trigger dtbs_check validation errors?

The mediatek,ufs.yaml binding specifies unevaluatedProperties: false and does
not define avdd12-supply, avdd12-ckbuf-supply, or avdd18-supply. These do not
appear in ufs-common.yaml either.

Additionally, since the kernel UFS and PHY drivers do not currently parse or
request regulators by these names, will these regulators remain unmanaged by
the UFS stack and potentially be powered off at runtime?

>  	vcc-supply = <&mt6359_vemc_1_ldo_reg>;
>  	vccq2-supply = <&mt6359_vufs_ldo_reg>;
>  };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260902-mediatek-ufs-cleanup-dts-v1-0-7876e7a27a9d@collabora.com?part=2