From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DEC24C624D0 for ; Wed, 2 Sep 2026 10:48:20 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x1iVd-0003BR-Ql; Wed, 02 Sep 2026 06:48:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x1iVc-0003BC-H3 for qemu-devel@nongnu.org; Wed, 02 Sep 2026 06:48:00 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x1iVb-0008K7-0O for qemu-devel@nongnu.org; Wed, 02 Sep 2026 06:48:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788346078; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hRpBem1a2l1MsZlhJeWWHN5s4jjpcAFUP3bEWjcRT1I=; b=MbAlBUrXUO6p1+zCsJyVgtoVryQ59WXwe+DS/WhL7DqInnl9HAVCpN5FMSHqvONIoUdVHg 1tYgItD+5i9qBON8rPQvTY2cKhL9YbOdu8H+3IORGAKuJmoolbqpqaeIrI/89Tz/zPUcWA 9vHmqTj40oEO8yNLkZy+gW26PB4w1VA= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-490-oI9DnwrZO7SQGjLmdju9Aw-1; Wed, 02 Sept 2026 06:47:56 -0400 X-MC-Unique: oI9DnwrZO7SQGjLmdju9Aw-1 X-Mimecast-MFC-AGG-ID: oI9DnwrZO7SQGjLmdju9Aw_1788346075 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A618E19344F7; Wed, 2 Sep 2026 10:47:55 +0000 (UTC) Received: from berrange.csb (headnet03.pony-001.prod.iad2.dc.redhat.com [10.2.32.114]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 66E913000223; Wed, 2 Sep 2026 10:47:54 +0000 (UTC) From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Peter Maydell , Markus Armbruster , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH v2] system: improve -mon deprecation warning Date: Wed, 2 Sep 2026 11:47:53 +0100 Message-ID: <20260902104753.1756783-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Expand the text a bit to make the new syntax more explicit and point users to the man page for further info. Reported-by: Peter Maydell Signed-off-by: Daniel P. Berrangé --- system/vl.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/system/vl.c b/system/vl.c index eded498fa7..d1d9209038 100644 --- a/system/vl.c +++ b/system/vl.c @@ -3239,8 +3239,13 @@ void qemu_init(int argc, char **argv) default_monitor = 0; break; case QEMU_OPTION_mon: - warn_report_once("'-mon' is deprecated, use '-object' with " - "'monitor-hmp' or 'monitor-qmp' types instead"); + warn_report_once( + "'-mon' is deprecated. Switch to either " + "'-object monitor-hmp,id=ID,chardev=CHR-ID' or " + "'-object monitor-qmp,id=ID,chardev=CHR-ID' instead. " + "See '-object' docs in the QEMU manual for further " + "configuration guidance: " + "https://www.qemu.org/docs/master/system/invocation.html"); if (!qemu_opts_parse_noisily(qemu_find_opts("mon"), optarg, true)) { exit(1); -- 2.55.0