Re: [PATCH v3 12/12] arm64: dts: renesas: ironhide: Add CPG/MDLC renesas,scmi-firmware properties

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The device tree patch references node labels (`&cpg` and numerous `&mdlc_*` nodes) that are never defined in the included `.dtsi` base files, causing a Device Tree Compiler (DTC) build failure.
--

commit 09da6ce12835b48b20d43a6bbc6347dc7ace67b7
Author: Geert Uytterhoeven <geert+renesas@glider.be>

arm64: dts: renesas: ironhide: Add CPG/MDLC renesas,scmi-firmware properties

This commit links the various Clock Pulse Generator (CPG) and Module
Controller (MDLC) device nodes to their SCMI provider by appending the
renesas,scmi-firmware properties.

> diff --git a/arch/arm64/boot/dts/renesas/r8a78000-ironhide.dts b/arch/arm64/boot/dts/renesas/r8a78000-ironhide.dts
> index 04291f04da2b7..a6f055a1f38a8 100644
> --- a/arch/arm64/boot/dts/renesas/r8a78000-ironhide.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a78000-ironhide.dts
> @@ -170,6 +170,10 @@ ecc@1e66660000 {
>  	};
>  };
>  
> +&cpg {
> +	renesas,scmi-firmware = <&scmi>;
> +};
> +

[Severity: Low]
Does this device tree compile cleanly? It appears the &cpg label is never
defined in the included base device tree files, which usually causes a
fatal "label or path not found" error during the dtbs build.

[ ... ]

>  
> +&mdlc_aon {
> +	renesas,scmi-firmware = <&scmi>;
> +};
> +

[Severity: Low]
Similarly, are the &mdlc_aon node and the numerous other &mdlc_* nodes that
follow defined in the base files? Attempting to modify nodes that do not
exist will also trigger a build breakage in the Device Tree Compiler.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1788338320.git.geert+renesas@glider.be?part=12