All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Kahola <mika.kahola@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: Mika Kahola <mika.kahola@intel.com>
Subject: [PATCH v2 1/2] drm/i915/display: Reject flipq for commits with no plane updates
Date: Wed,  2 Sep 2026 11:55:31 +0000	[thread overview]
Message-ID: <20260902115531.872831-1-mika.kahola@intel.com> (raw)
In-Reply-To: <20260902105448.809455-2-mika.kahola@intel.com>

flipq is pointless without an actual plane update to queue. Reject it.

v2:
- Drop the single-plane restriction, plane count doesn't matter (Ville)
- Drop the update_wm_pre/post check, dead code for flipq-capable hw (Ville)
- Drop the active/enabled planes check (Ville)
- Drop the update_pipe/update_m_n/update_lrr check -- unreachable,
  intel_crtc_needs_fastset() above is exactly update_pipe, and
  update_m_n/update_lrr can only be set alongside it or a full modeset,
  both already excluded (Sashiko AI review)
- Drop the intel_flipq_commit_is_eligible() helper -- with the above
  gone, all that's left is one extra check, not worth its own function
  for a single call site

Assisted-by: Copilot:claude-sonnet-5
Signed-off-by: Mika Kahola <mika.kahola@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 553c60d452dd..9272fe573ae2 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -7385,6 +7385,7 @@ static void intel_atomic_dsb_prepare(struct intel_atomic_state *state,
 	/* FIXME deal with everything */
 	new_crtc_state->use_flipq =
 		intel_flipq_supported(display) &&
+		new_crtc_state->update_planes &&
 		!new_crtc_state->do_async_flip &&
 		!new_crtc_state->vrr.enable &&
 		!new_crtc_state->has_psr &&
-- 
2.43.0


  parent reply	other threads:[~2026-09-02 11:55 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-02 10:54 [PATCH v2 0/2] drm/i915/display: fix flipq pipe CRC mismatch in kms_cursor_crc Mika Kahola
2026-09-02 10:54 ` [PATCH v2 1/2] drm/i915/display: Reject flipq for pipe or timing changes Mika Kahola
2026-09-02 11:07   ` sashiko-bot
2026-09-02 11:55   ` Mika Kahola [this message]
2026-09-02 11:59   ` Jani Nikula
2026-09-02 12:24     ` Kahola, Mika
2026-09-02 12:27   ` Ville Syrjälä
2026-09-02 13:52     ` Kahola, Mika
2026-09-02 10:54 ` [PATCH v2 2/2] drm/i915/display: Reset use_flipq when duplicating crtc state Mika Kahola
2026-09-02 13:33   ` Ville Syrjälä
2026-09-02 14:08     ` Kahola, Mika
2026-09-02 11:26 ` ✓ CI.KUnit: success for drm/i915/display: fix flipq pipe CRC mismatch in kms_cursor_crc (rev2) Patchwork
2026-09-02 11:53 ` ✓ i915.CI.BAT: " Patchwork
2026-09-02 12:13 ` ✓ CI.KUnit: success for drm/i915/display: fix flipq pipe CRC mismatch in kms_cursor_crc (rev3) Patchwork
2026-09-02 12:19 ` ✗ Xe.CI.BAT: failure for drm/i915/display: fix flipq pipe CRC mismatch in kms_cursor_crc (rev2) Patchwork
2026-09-02 12:59 ` ✓ Xe.CI.BAT: success for drm/i915/display: fix flipq pipe CRC mismatch in kms_cursor_crc (rev3) Patchwork
2026-09-02 13:01 ` ✓ i915.CI.BAT: " Patchwork
2026-09-02 22:42 ` ✓ Xe.CI.FULL: " Patchwork
2026-09-03  3:37 ` ✗ i915.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260902115531.872831-1-mika.kahola@intel.com \
    --to=mika.kahola@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.