All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Yifei Chu <Chuyf26@linux.alibaba.com>
Cc: kbusch@kernel.org, sagi@grimberg.me, hch@lst.de,
	linux-nvme@lists.infradead.org
Subject: Re: [PATCH v3] nvmet: verify the hostid when looking up a controller
Date: Wed, 2 Sep 2026 16:04:00 +0200	[thread overview]
Message-ID: <20260902140400.GB23598@lst.de> (raw)
In-Reply-To: <178814381141.3422569.11201888645559295686@linux.alibaba.com>

On Mon, Aug 31, 2026 at 10:36:51AM +0800, Yifei Chu wrote:
> nvmet_ctrl_find_get() matches controllers by cntlid and hostnqn only.
> The connect data also carries the connecting host's hostid, but it is
> never compared against the hostid the controller was created with, so
> the lookup can return a controller whose recorded hostid differs.

So?  The hostid does not identify a controller.



  reply	other threads:[~2026-09-02 14:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-27 10:12 [PATCH v2] nvmet: verify the hostid when looking up a controller Yifei Chu
2026-08-30 21:27 ` Sagi Grimberg
2026-08-31  2:36   ` [PATCH v3] " Yifei Chu
2026-09-02 14:04     ` Christoph Hellwig [this message]
2026-09-03  2:37       ` Yifei Chu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260902140400.GB23598@lst.de \
    --to=hch@lst.de \
    --cc=Chuyf26@linux.alibaba.com \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.