Re: [PATCH] xfs: basic functional testing of media verification command

["Darrick J. Wong" <djwong@kernel.org>]

On Wed, Sep 02, 2026 at 09:29:33AM +0200, Christoph Hellwig wrote:
> > diff --git a/common/xfs b/common/xfs
> > index 81add2086866c8..8dec3475579e40 100644
> > --- a/common/xfs
> > +++ b/common/xfs
> > @@ -1786,6 +1786,9 @@ _xfs_filter_mkfs()
> >  	}
> >  	if (/^\s+=\s+rgcount=(\d+)\s+rgsize=(\d+) extents/) {
> >  		print STDERR "rgcount=$1\nrgextents=$2\n";
> > +	}
> > +	if (/^\s+=\s+zoned=(\d+)\s+start=(\d+) reserved=(\d+)/) {
> > +		print STDERR "zoned=$1\nrtstart=$2\nrtreserved=$3\n";
> >  	}'
> 
> How is this related?  Maybe split it out into a well-doumented patch?

The test sources $tmp.mkfs and reads the rtstart= variable that is
created by the addition to _xfs_filter_mkfs.  I'll split this into its
own patch with a separate justification.

> Also does the ' after the } break the usage?

No, because it's an awk script embedded in a bash string argument.

> > +
> > +# Make the data and rt volumes small enough that this won't take forever
> > +# on large slow devices.
> > +_scratch_mkfs_sized $((600 * 1024 * 1024)) | _filter_mkfs 2>$tmp.mkfs >> $seqres.full
> 
> Split the overly long line?

Ok.

> Otherwise this looks good to me.

Thanks!

--D