From: George Zhang <george.zhang@amd.com>
To: <igt-dev@lists.freedesktop.org>
Cc: Fangzhi Zuo <jerry.zuo@amd.com>,
Ivan Lipski <ivan.lipski@amd.com>,
"Alex Hung" <alex.hung@amd.com>,
Harry Wentland <harry.wentland@amd.com>,
"George Zhang" <george.zhang@amd.com>
Subject: [i-g-t 1/2] tests/amdgpu/amd_dp_dsc: Do not disable DSC for high bw panels
Date: Wed, 2 Sep 2026 11:57:13 -0400 [thread overview]
Message-ID: <20260902155742.990457-1-george.zhang@amd.com> (raw)
The test previously attempted to disable DSC even on high bandwidth
panels. This would erroneously fail the dsc_enable test even though DSC
is on.
Fix this by checking what mode the panel defaults to when set to
automatic. If DSC is on, then do not attempt to force it off later.
Signed-off-by: George Zhang <george.zhang@amd.com>
---
tests/amdgpu/amd_dp_dsc.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/tests/amdgpu/amd_dp_dsc.c b/tests/amdgpu/amd_dp_dsc.c
index dc71e903e..ccaf64c66 100644
--- a/tests/amdgpu/amd_dp_dsc.c
+++ b/tests/amdgpu/amd_dp_dsc.c
@@ -137,6 +137,9 @@ static void test_dsc_enable(data_t *data)
igt_output_set_crtc(output,
crtc);
igt_plane_set_fb(data->primary[crtc->crtc_index], &ref_fb);
+
+ /* Make sure we are in automatic mode before we start*/
+ igt_amd_write_dsc_clock_en(data->fd, output->name, DSC_AUTOMATIC);
igt_display_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET, 0);
test_conn_cnt++;
@@ -154,7 +157,9 @@ static void test_dsc_enable(data_t *data)
dsc_on = igt_amd_read_dsc_clock_status(data->fd, output->name) == 1;
/* Revert DSC to automatic state */
- igt_amd_write_dsc_clock_en(data->fd, output->name, DSC_FORCE_OFF);
+ if (!dsc_before)
+ /* We can only force off if the panel allows it. If DSC was on in automatic mode, we cannot force it off. */
+ igt_amd_write_dsc_clock_en(data->fd, output->name, DSC_FORCE_OFF);
igt_plane_set_fb(data->primary[crtc->crtc_index], &ref_fb);
igt_display_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
@@ -286,6 +291,7 @@ static void test_dsc_slice_dimensions_change(data_t *data)
igt_output_set_crtc(output,
crtc);
igt_plane_set_fb(data->primary[crtc->crtc_index], &ref_fb);
+ igt_amd_write_dsc_clock_en(data->fd, output->name, DSC_AUTOMATIC);
igt_display_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET, 0);
test_conn_cnt++;
@@ -317,7 +323,8 @@ static void test_dsc_slice_dimensions_change(data_t *data)
}
/* Force disable DSC */
- igt_amd_write_dsc_clock_en(data->fd, output->name, DSC_FORCE_OFF);
+ if (!dsc_before)
+ igt_amd_write_dsc_clock_en(data->fd, output->name, DSC_FORCE_OFF);
igt_plane_set_fb(data->primary[crtc->crtc_index], &ref_fb);
igt_display_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
--
2.55.0
next reply other threads:[~2026-09-02 15:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 15:57 George Zhang [this message]
2026-09-02 15:57 ` [i-g-t 2/2] tests/amdgpu/amd_dp_dsc: Reset link settings after subtest George Zhang
2026-09-03 18:39 ` Alex Hung
2026-09-02 22:53 ` ✓ i915.CI.BAT: success for series starting with [i-g-t,1/2] tests/amdgpu/amd_dp_dsc: Do not disable DSC for high bw panels Patchwork
2026-09-02 22:59 ` ✓ Xe.CI.BAT: " Patchwork
2026-09-03 14:55 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-09-03 18:29 ` [i-g-t 1/2] " Alex Hung
2026-09-03 19:17 ` George Zhang
2026-09-03 19:12 ` ✓ i915.CI.Full: success for series starting with [i-g-t,1/2] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260902155742.990457-1-george.zhang@amd.com \
--to=george.zhang@amd.com \
--cc=alex.hung@amd.com \
--cc=harry.wentland@amd.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=ivan.lipski@amd.com \
--cc=jerry.zuo@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.