From: Jakub Kicinski <kuba@kernel.org>
To: Xuanqiang Luo <xuanqiang.luo@linux.dev>, huhai <15815827059@163.com>
Cc: netdev@vger.kernel.org, huhai <huhai@kylinos.cn>,
andrew@lunn.ch, divya.koppera@microchip.com
Subject: Re: [PATCH] net: phy: microchip_t1: fix NULL pointer dereference in lan887x_phy_init()
Date: Wed, 2 Sep 2026 15:58:25 -0700 [thread overview]
Message-ID: <20260902155825.63974224@kernel.org> (raw)
In-Reply-To: <a59a2f22-dca0-443b-a0de-f580ed2c4438@linux.dev>
On Wed, 2 Sep 2026 17:16:48 +0800 Xuanqiang Luo wrote:
> > mchp_rds_ptp_probe() may return NULL when CONFIG_PTP_1588_CLOCK is disabled.
>
> When CONFIG_MICROCHIP_PHY_RDS_PTP=n, the stub for
> mchp_rds_ptp_probe() also returns NULL, even if
> CONFIG_PTP_1588_CLOCK=y. Please mention this case in the commit message.
Speaking of improvements to the commits message - please also explain
how the issue was found, reproduced, and fix validated.
It'd be good to improve the spalling of your name (rather just
repeating your email login) a little; or just add your real name in
unicode characters in () brackets, like huhai ($unicode chars) <email>.
next prev parent reply other threads:[~2026-09-02 22:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 8:33 [PATCH] net: phy: microchip_t1: fix NULL pointer dereference in lan887x_phy_init() huhai
2026-09-02 8:56 ` Divya.Koppera
2026-09-02 9:16 ` Xuanqiang Luo
2026-09-02 22:58 ` Jakub Kicinski [this message]
2026-09-03 9:01 ` huhai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260902155825.63974224@kernel.org \
--to=kuba@kernel.org \
--cc=15815827059@163.com \
--cc=andrew@lunn.ch \
--cc=divya.koppera@microchip.com \
--cc=huhai@kylinos.cn \
--cc=netdev@vger.kernel.org \
--cc=xuanqiang.luo@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.