From: linuxtestproject.agent@gmail.com
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] coredump01: New core_pattern specifiers test
Date: Wed, 2 Sep 2026 17:44:00 +0000 [thread overview]
Message-ID: <20260902174400.9226-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260902-coredump-v4-1-3f511ea1c96a@suse.com>
Hi Andrea,
On September 2, 2026, Andrea Cervesato wrote:
> coredump01: New core_pattern specifiers test
> if (tst_get_path(HELPER, helper_path, sizeof(helper_path)))
> tst_brk(TCONF, "'%s' not found in $PATH", HELPER);
`tst_get_path()` can return a relative path such as
`./coredump01_helper`, but a piped core_pattern helper is resolved from
the root directory. Canonicalize `helper_path` to an absolute path before
writing it to core_pattern, otherwise the helper may not start and the
test reports a false failure.
Verdict - Needs revision
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-09-02 17:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 15:00 [LTP] [PATCH v4] coredump01: New core_pattern specifiers test Andrea Cervesato
2026-09-02 17:44 ` linuxtestproject.agent [this message]
2026-09-03 7:22 ` [LTP] " Andrea Cervesato via ltp
-- strict thread matches above, loose matches on Subject: below --
2026-09-08 6:26 [LTP] [PATCH v8 1/2] " Andrea Cervesato
2026-09-08 6:48 ` [LTP] " linuxtestproject.agent
2026-09-04 11:03 [LTP] [PATCH v7 1/2] " Andrea Cervesato
2026-09-04 12:20 ` [LTP] " linuxtestproject.agent
2026-09-04 12:26 ` Andrea Cervesato via ltp
2026-09-08 6:27 ` Andrea Cervesato via ltp
2026-09-04 7:15 [LTP] [PATCH v6 1/2] " Andrea Cervesato
2026-09-04 7:52 ` [LTP] " linuxtestproject.agent
2026-09-03 7:21 [LTP] [PATCH v5] " Andrea Cervesato
2026-09-03 12:01 ` [LTP] " linuxtestproject.agent
2026-08-24 8:58 [LTP] [PATCH v3] " Andrea Cervesato
2026-08-24 9:49 ` [LTP] " linuxtestproject.agent
2026-08-24 8:38 [LTP] [PATCH v2] " Andrea Cervesato
2026-08-24 8:55 ` [LTP] " linuxtestproject.agent
2026-08-20 18:47 [LTP] [PATCH] " Andrea Cervesato
2026-08-20 19:35 ` [LTP] " linuxtestproject.agent
2026-08-24 7:22 ` Andrea Cervesato via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260902174400.9226-1-linuxtestproject.agent@gmail.com \
--to=linuxtestproject.agent@gmail.com \
--cc=andrea.cervesato@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.