All of lore.kernel.org
 help / color / mirror / Atom feed
From: Davidlohr Bueso <dave@stgolabs.net>
To: Anisa Su <anisa.su887@gmail.com>
Cc: linux-cxl@vger.kernel.org, benjamin.cheatham@amd.com,
	icheng@nvidia.com, dave.jiang@intel.com,
	alison.schofield@intel.com, jic23@kernel.org
Subject: Re: [PATCH v2 0/4] cxl/events: Robustify event interrupt handling
Date: Wed, 2 Sep 2026 12:06:22 -0700	[thread overview]
Message-ID: <20260902190622.aymrxkyfiiu7yuco@offworld> (raw)
In-Reply-To: <apfd9eH0cVxMJJ5F@4470NRD-ASU.ssi.samsung.com>

On Wed, 02 Sep 2026, Anisa Su wrote:

>On Mon, Aug 31, 2026 at 05:26:53PM -0700, Anisa Su wrote:
>> Based on the 7.2 tag.
>>
>> This patchset bundles various fixes along the event interrupt path.
>> The previous revision was a single patch, but Sashiko reported several
>> related pre-existing errors so I thought I may as well pick them all up into
>> one series.
>>
>> Link to v1:
>> https://lore.kernel.org/linux-cxl/cover.1787768932.git.anisa.su@samsung.com/T/#m393e57d7f7f3916e8f2826a006ef0bc4dfd3606a
>>
>Had a chat with Dave and he mentioned we only need to deal with device quirks
>when they show up. So I plan to drop patches 2-4, since they are just Sashiko
>reports and not observed on hardware.
>
>For patch 1, there are a few considerations, so if any maintainers could have a quick
>glance at the thread?
>
>1. I did observe the bug on hardware, but it's a sample device and the
>firmware is being patched, so nobody should see it happen IRL? The consequences
>of the issue were:

I think this says it all, and therefore is not a quirk imo. We should not cater
to flat out spec violations (for non-public hw/fw) - there are plenty of things
that could easily break all over the place if bits are not set/unset by hardware
when it is supposed to.

So I would pretend this never occurred, and if someone ever complains (it was seen
IRL) we have your solution at hand.

>	- 1 CPU taken up
>	- driver can't be unbound since free_irq() waits for threads_active = 0
>
>2. Li Ming mentioned checking the return value of cxl_mem_get_event_records()
>is still valuable (currently a void function). So we could drop the other
>changes from the patch and just keep that part.

Yes, I agree.

Thanks,
Davidlohr

      reply	other threads:[~2026-09-02 20:23 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-01  0:26 [PATCH v2 0/4] cxl/events: Robustify event interrupt handling Anisa Su
2026-09-01  0:26 ` [PATCH v2 1/4] cxl/events: Bound get records loop in cxl_event_thread() Anisa Su
2026-09-01  0:41   ` sashiko-bot
2026-09-01 11:48   ` Li Ming
2026-09-01 17:59     ` Anisa Su
2026-09-01 19:17   ` Cheatham, Benjamin
2026-09-01  0:26 ` [PATCH v2 2/4] cxl/events: Validate the record count reported by the device Anisa Su
2026-09-01 19:19   ` Cheatham, Benjamin
2026-09-01  0:26 ` [PATCH v2 3/4] cxl/events: Bound the per-log Get Event Records loop Anisa Su
2026-09-01  0:43   ` sashiko-bot
2026-09-01 19:19   ` Cheatham, Benjamin
2026-09-01  0:26 ` [PATCH v2 4/4] cxl/events: Return IRQ_NONE when no events were processed Anisa Su
2026-09-01  0:38   ` sashiko-bot
2026-09-01 19:19   ` Cheatham, Benjamin
2026-09-08 22:26     ` Jonathan Cameron
2026-09-02  8:27 ` [PATCH v2 0/4] cxl/events: Robustify event interrupt handling Anisa Su
2026-09-02 19:06   ` Davidlohr Bueso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260902190622.aymrxkyfiiu7yuco@offworld \
    --to=dave@stgolabs.net \
    --cc=alison.schofield@intel.com \
    --cc=anisa.su887@gmail.com \
    --cc=benjamin.cheatham@amd.com \
    --cc=dave.jiang@intel.com \
    --cc=icheng@nvidia.com \
    --cc=jic23@kernel.org \
    --cc=linux-cxl@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.