Re: [PATCH 4/5] selftests: KVM: guest_memfd: let the gmem_test() harness bind a node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Build failure due to missing tools UAPI header sync for GUEST_MEMFD_FLAG_BIND_NODE.
--

commit 93b29e02dbc130205238f8312d9571e48df529a8
Author: Gregory Price <gourry@gourry.net>
Subject: selftests: KVM: guest_memfd: let the gmem_test() harness bind a node

This commit extends create_guest_memfd() to accept a node argument in order
to test the GUEST_MEMFD_FLAG_BIND_NODE functionality. It ignores the node
argument if the BIND_NODE flag is not provided.

> diff --git a/tools/testing/selftests/kvm/guest_memfd_test.c b/tools/testing/selftests/kvm/guest_memfd_test.c
> index 2233d871a38f4..1818e0fea5690 100644
> --- a/tools/testing/selftests/kvm/guest_memfd_test.c
> +++ b/tools/testing/selftests/kvm/guest_memfd_test.c
> @@ -25,6 +25,31 @@
>  
>  static size_t page_size;
>  
> +static int __create_guest_memfd_node(struct kvm_vm *vm, u64 size, u64 flags,
> +				     u32 node, u32 pad)
> +{
> +	struct kvm_create_guest_memfd guest_memfd = {
> +		.size = size,
> +		.flags = flags,
> +		.node = node,
> +		.pad = pad,
> +	};

[Severity: Low]
Does this cause a build failure when compiling the KVM selftests?

This patch updates the tests to use the new .node and .pad fields in
struct kvm_create_guest_memfd here, as well as the
GUEST_MEMFD_FLAG_BIND_NODE macro further down.

However, the tools/include/uapi/linux/kvm.h header doesn't seem to be
synchronized in this patch. Because the selftests Makefile prioritizes
the tools/include path over system headers, won't the compiler fail with
undeclared identifier errors when it processes these new fields and macros?

Should tools/include/uapi/linux/kvm.h be updated either in this patch or
in a prerequisite commit to prevent breaking the local build?

> +
> +	return __vm_ioctl(vm, KVM_CREATE_GUEST_MEMFD, &guest_memfd);
> +}
> +
> +static int create_guest_memfd(struct kvm_vm *vm, u64 size, u64 flags, u32 node)
> +{
> +	int fd;
> +
> +	if (!(flags & GUEST_MEMFD_FLAG_BIND_NODE))
> +		return vm_create_guest_memfd(vm, size, flags);
> +
> +	fd = __create_guest_memfd_node(vm, size, flags, node, 0);
> +	TEST_ASSERT(fd >= 0, KVM_IOCTL_ERROR(KVM_CREATE_GUEST_MEMFD, fd));
> +	return fd;
> +}

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260902194657.79075-1-gourry@gourry.net?part=4