All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Kendall Willis" <k-willis@ti.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/3] arm64: dts: ti: k3-am62: use ti,am62-m_can compatible for m_can devices
Date: Wed, 02 Sep 2026 21:16:25 +0000	[thread overview]
Message-ID: <20260902211625.7EAAF1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260902-smth-v2-1-b3678ca44c7b@ti.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch introduces a new device tree compatible string 'ti,am62-m_can' without updating the corresponding device tree binding schema, which will cause dtbs_check validation failures.
--

commit aab89344d119641f5683480ba4bd99f51381ae13
Author: Kendall Willis <k-willis@ti.com>

arm64: dts: ti: k3-am62: use ti,am62-m_can compatible for m_can devices

This commit prepends the "ti,am62-m_can" compatible string to the m_can
devices in the k3-am62-mcu device tree. This change reflects the out-of-band
wakeup functionality available for these devices during deeper low power
states.

> diff --git a/arch/arm64/boot/dts/ti/k3-am62-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62-mcu.dtsi
> --- a/arch/arm64/boot/dts/ti/k3-am62-mcu.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-mcu.dtsi
> @@ -152,7 +152,7 @@ mcu_rti0: watchdog@4880000 {
>  	};
>  
>  	mcu_mcan0: can@4e08000 {
> -		compatible = "bosch,m_can";
> +		compatible = "ti,am62-m_can", "bosch,m_can";

[Severity: Low]
Will adding "ti,am62-m_can" here trigger a dtbs_check validation failure?

The existing schema for the Bosch M_CAN controller in
Documentation/devicetree/bindings/net/can/bosch,m_can.yaml expects the
compatible property to strictly be bosch,m_can. 

Changing it to an array without updating the YAML schema will likely cause
DT validation tools to fail during the build process.

Should the binding schema be updated alongside this change?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260902-smth-v2-0-b3678ca44c7b@ti.com?part=1

  reply	other threads:[~2026-09-02 21:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-02 21:04 [PATCH v2 0/3] arm64: dts: ti: use ti,am62-m_can compatible for m_can devices Kendall Willis
2026-09-02 21:04 ` [PATCH v2 1/3] arm64: dts: ti: k3-am62: " Kendall Willis
2026-09-02 21:16   ` sashiko-bot [this message]
2026-09-02 21:04 ` [PATCH v2 2/3] arm64: dts: ti: k3-am62a: " Kendall Willis
2026-09-02 21:16   ` sashiko-bot
2026-09-02 21:04 ` [PATCH v2 3/3] arm64: dts: ti: k3-am62p: " Kendall Willis
2026-09-02 21:13   ` sashiko-bot
2026-09-04 14:09   ` Kumar, Udit
2026-09-04 14:59     ` Kendall Willis
2026-09-11  3:55       ` Nishanth Menon
2026-09-11 14:32         ` Kendall Willis
2026-09-11 19:19           ` Nishanth Menon
2026-09-11 19:46             ` Kendall Willis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260902211625.7EAAF1F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=k-willis@ti.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.