Re: [PATCH] arm64: tegra: Move Tegra210 AHUB audio ports/endpoints to SoC DTSI

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch moves the AHUB internal audio ports and endpoints to `tegra210.dtsi` to share them across all Tegra210 boards, but fails to remove the identical redundant routing definitions from `tegra210-p3450-0000.dts` (Jetson Nano).
--

commit 583871624e297ed1aca069075c249e3cbd7ee179
Author: Diogo Ivo <diogo.ivo@bootlin.com>

arm64: tegra: Move Tegra210 AHUB audio ports/endpoints to SoC DTSI

This commit moves the AHUB internal audio ports and endpoints from the
tegra210-p2371-2180 board file into the shared tegra210.dtsi file. This
refactoring allows these definitions to be shared across all Tegra210-based
boards.

> Move them from tegra210-p2371-2180.dts into tegra210.dtsi so
> they can be shared by all Tegra210-based boards.

[Severity: Low]
Should the equivalent redundant routing definitions also be removed from
arch/arm64/boot/dts/nvidia/tegra210-p3450-0000.dts?

Since the endpoints are now in the shared tegra210.dtsi, the Jetson Nano
board file currently retains duplicate definitions. While the DTC compiler
merges identical node paths without error, leaving these behind bypasses
the benefits of this refactoring.

For example, the board file still has redundant endpoints such as:

i2s3_cif_ep: endpoint {
	remote-endpoint = <&xbar_i2s3_ep>;
};

And redundant port definitions such as:

xbar_i2s3_port: port@c {
	reg = <0xc>;

	xbar_i2s3_ep: endpoint {
		remote-endpoint = <&i2s3_cif_ep>;
	};
};

Would it make sense to clean up these duplicates as part of this patch?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260903-smaug-audio_ports-v1-1-d4605332d8d4@bootlin.com?part=1