From: sashiko-bot@kernel.org
To: "Judith Mendez" <jm@ti.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: nvmem: uniphier-efuse: Add ti,am62p-efuse compatible
Date: Wed, 02 Sep 2026 22:34:54 +0000 [thread overview]
Message-ID: <20260902223455.52B461F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260902222759.736124-2-jm@ti.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The Device Tree binding groups an unrelated Texas Instruments compatible string (`ti,am62p-efuse`) into the Socionext Uniphier eFuse schema strictly to reuse a Linux driver, violating the rule that DT bindings must describe hardware.
--
commit bf8e60a2409a1898bd121ebca26b279cdf4f85e7
Author: Judith Mendez <jm@ti.com>
dt-bindings: nvmem: uniphier-efuse: Add ti,am62p-efuse compatible
This commit adds the ti,am62p-efuse compatible string to the Socionext
Uniphier eFuse binding. The commit message notes this is done so the
existing uniphier-efuse Linux driver can be used to read AM62P efuse
registers for silicon revision detection.
> diff --git a/Documentation/devicetree/bindings/nvmem/socionext,uniphier-efuse.yaml b/Documentation/devicetree/bindings/nvmem/socionext,uniphier-efuse.yaml
> index e27cbae2d63a0..5e1b90fc1ae45 100644
> --- a/Documentation/devicetree/bindings/nvmem/socionext,uniphier-efuse.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/socionext,uniphier-efuse.yaml
> @@ -16,7 +16,9 @@ allOf:
>
> properties:
> compatible:
> - const: socionext,uniphier-efuse
> + enum:
> + - socionext,uniphier-efuse
> + - ti,am62p-efuse
[Severity: Low]
Does grouping an unrelated Texas Instruments compatible string into a
Socionext binding conflict with the rule that Device Tree schemas must
describe hardware blocks rather than software driver mappings? Grouping
hardware from different vendors strictly to reuse a Linux driver creates
an inaccurate hardware description.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260902222759.736124-1-jm@ti.com?part=1
next prev parent reply other threads:[~2026-09-02 22:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 22:27 [PATCH v2 0/3] Support AM62P silicon revision detection via uniphier-efuse Judith Mendez
2026-09-02 22:27 ` [PATCH v2 1/3] dt-bindings: nvmem: uniphier-efuse: Add ti,am62p-efuse compatible Judith Mendez
2026-09-02 22:34 ` sashiko-bot [this message]
2026-09-03 18:00 ` Conor Dooley
2026-09-08 20:28 ` Judith Mendez
2026-09-09 10:02 ` Conor Dooley
2026-09-10 14:32 ` Judith Mendez
2026-09-02 22:27 ` [PATCH v2 2/3] nvmem: uniphier-efuse: Enable for K3 SoCs Judith Mendez
2026-09-02 22:38 ` sashiko-bot
2026-09-02 22:27 ` [PATCH v2 3/3] nvmem: uniphier-efuse: Add ti,am62p-efuse compatible Judith Mendez
2026-09-02 22:34 ` sashiko-bot
2026-09-03 10:06 ` [PATCH v2 0/3] Support AM62P silicon revision detection via uniphier-efuse Kunihiko Hayashi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260902223455.52B461F00A3A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jm@ti.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.