From: Mohsin Bashir <mohsin.bashr@gmail.com>
To: mkubecek@suse.cz
Cc: netdev@vger.kernel.org, kuba@kernel.org, mohsin.bashr@gmail.com
Subject: [PATCH ethtool 3/3] ethtool: fbnic: Fix register dump names and bit labels
Date: Wed, 2 Sep 2026 16:07:39 -0700 [thread overview]
Message-ID: <20260902230739.2241212-4-mohsin.bashr@gmail.com> (raw)
In-Reply-To: <20260902230739.2241212-1-mohsin.bashr@gmail.com>
From: Mohsin Bashir <hmohsin@meta.com>
Use the hardware register names for the TQS global and TNI status registers.
While at it, print full-width status values, and fix the incorrect bit-range
and field labels.
Fixes: a38a2d3a8271 ("ethtool: fbnic: ethtool dump parser")
Signed-off-by: Mohsin Bashir <hmohsin@meta.com>
---
fbnic.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/fbnic.c b/fbnic.c
index c9d217b..e946ee3 100644
--- a/fbnic.c
+++ b/fbnic.c
@@ -5944,7 +5944,7 @@ static int fbnic_dump_fb_nic_qm_tx_global(uint32_t **regs_buffp,
break;
case FBNIC_QM_TQS_MTU_STS_0:
fprintf(stdout,
- "FBNIC_QM_TQS_MTU_STS_0: 0x%08x\n",
+ "FBNIC_QM_TQS_GLOBAL_STS0: 0x%08x\n",
reg_val);
m = FBNIC_QM_TQS_STS0_TXB_MC_FIFO_CRDTS_USED;
bf_val = FIELD_GET(m, reg_val);
@@ -5953,7 +5953,7 @@ static int fbnic_dump_fb_nic_qm_tx_global(uint32_t **regs_buffp,
break;
case FBNIC_QM_TQS_MTU_STS_1:
fprintf(stdout,
- "FBNIC_QM_TQS_MTU_STS_1: 0x%08x\n",
+ "FBNIC_QM_TQS_GLOBAL_STS1: 0x%08x\n",
reg_val);
m = FBNIC_QM_TQS_STS1_TXB_BMC_FIFO_CRDTS_USED;
bf_val = FIELD_GET(m, reg_val);
@@ -6188,7 +6188,7 @@ static int fbnic_dump_fb_nic_qm_tx_global(uint32_t **regs_buffp,
break;
case FBNIC_QM_TNI_TCM_STS:
fprintf(stdout,
- "FBNIC_QM_TNI_TCM_STS: 0x%02x\n",
+ "FBNIC_QM_TNI_STS: 0x%08x\n",
reg_val);
m = FBNIC_QM_TNI_TCM_STS_TDF_NOCIF_IDLE;
bf_val = FIELD_GET(m, reg_val);
@@ -6670,7 +6670,7 @@ static int fbnic_dump_fb_nic_qm_rx_global(uint32_t **regs_buffp,
m = FBNIC_QM_RNI_STS_RCM_IDLE_DP;
bf_val = FIELD_GET(m, reg_val);
fprintf(stdout,
- " [02:02] RCM_NOCIF_IDLE_DP: 0x%02x\n",
+ " [05:05] RCM_NOCIF_IDLE_DP: 0x%02x\n",
bf_val);
break;
case FBNIC_QM_RNI_ERR_INTR_STS:
@@ -7194,7 +7194,7 @@ static int fbnic_dump_fb_nic_tce(uint32_t **regs_buffp,
i, reg_val);
m = FBNIC_TCE_TXB_DATA_Q_LVL_VALUE;
bf_val = FIELD_GET(m, reg_val);
- fprintf(stdout, " [12:00] FIFO_LEVEL: 0x%05x\n",
+ fprintf(stdout, " [11:00] FIFO_LEVEL: 0x%05x\n",
bf_val);
break;
case FBNIC_TCE_TXB_INGR_Q_LVL:
@@ -7578,11 +7578,11 @@ static int fbnic_dump_fb_nic_tce_ram(uint32_t **regs_buffp,
bf_val);
m = FBNIC_TCE_RAM_TCAM3_MCQ_MASK;
bf_val = FIELD_GET(m, reg_val);
- fprintf(stdout, " [06:06] MCQ MASK: 0x%02x\n",
+ fprintf(stdout, " [07:07] MCQ MASK: 0x%02x\n",
bf_val);
m = FBNIC_TCE_RAM_TCAM3_VALIDATE;
bf_val = FIELD_GET(m, reg_val);
- fprintf(stdout, " [31:31] MCQ MASK: 0x%02x\n",
+ fprintf(stdout, " [31:31] VALIDATE: 0x%02x\n",
bf_val);
break;
default:
--
2.53.0-Meta
next prev parent reply other threads:[~2026-09-02 23:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 23:07 [PATCH ethtool 0/3] ethtool: fbnic: Fix register dump parser Mohsin Bashir
2026-09-02 23:07 ` [PATCH ethtool 1/3] ethtool: fbnic: fix off-by-one shift in reg " Mohsin Bashir
2026-09-02 23:07 ` [PATCH ethtool 2/3] ethtool: fbnic: Fix various TX and RX CSR fields decoding Mohsin Bashir
2026-09-02 23:07 ` Mohsin Bashir [this message]
2026-09-14 19:40 ` [PATCH ethtool 0/3] ethtool: fbnic: Fix register dump parser patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260902230739.2241212-4-mohsin.bashr@gmail.com \
--to=mohsin.bashr@gmail.com \
--cc=kuba@kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.