From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B6B1C624A4 for ; Thu, 3 Sep 2026 08:12:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D1A5910F45E; Thu, 3 Sep 2026 08:12:24 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.b="1o2PoOZo"; dkim-atps=neutral Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) by gabe.freedesktop.org (Postfix) with ESMTPS id 467CF10F45E for ; Thu, 3 Sep 2026 08:12:23 +0000 (UTC) Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 1581C4E414F2; Thu, 3 Sep 2026 08:12:22 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id DC319602B8; Thu, 3 Sep 2026 08:12:21 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 8465211C79F4D; Thu, 3 Sep 2026 10:12:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1788423140; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=pPgqqB8slFMQr5Kpl6JRMxMiHaZVEfJqqUfrSa3/Ilg=; b=1o2PoOZo+DtGsRxxzjrT/1G89edmkPpDh1cVQRxL3uqGp4HuRlWG43GBHQ6f1btv/8gp9U MiMJhkdNDKNRs2FSbDVqT4kxgHHGaBmi1N1qVNT9tSy5y4sm4Un+heWEE+W8NpWgkp6DXj MrQPO1F9zB2tGWr3iKlRxla1yVDcaTKHjJ3L3Ois+9XuEAs1GNsV7lDesKpvtaoOmJLCnT dFwfAXiuANQfmJFCbcz2iLm8DQEN/tIIxtJjxRBmc4AaEP6BmpCd3l0nQS2dmvyKqjzfs7 Vnj0T4/37iuVTWbZOWjBez2Fb2c/N8lbqOiaHTdM/5DN6CXwYUk6s3ny94JUKA== From: Luca Ceresoli Date: Thu, 03 Sep 2026 10:11:11 +0200 Subject: [PATCH RFC v2 08/19] drm/mcde: dsi: simplify device_node management using scoped for_each variant MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260903-drm-bridge-every-panel-v2-8-2ab8ee24538e@bootlin.com> References: <20260903-drm-bridge-every-panel-v2-0-2ab8ee24538e@bootlin.com> In-Reply-To: <20260903-drm-bridge-every-panel-v2-0-2ab8ee24538e@bootlin.com> To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Jessica Zhang , Linus Walleij , Inki Dae , Jagan Teki , Marek Szyprowski Cc: Albert Esteve , Anusha Srivatsa , Dmitry Baryshkov , Hui Pu , Ian Ray , Thomas Petazzoni , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Luca Ceresoli X-Mailer: b4 0.16.0 X-Last-TLS-Session-Version: TLSv1.3 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Before further modifying this function, simpify the struct device_node management using the scoped variat of for_each_available_child_of_node(). Reviewed-by: Maxime Ripard Reviewed-by: Linus Walleij Signed-off-by: Luca Ceresoli --- drivers/gpu/drm/mcde/mcde_dsi.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/mcde/mcde_dsi.c b/drivers/gpu/drm/mcde/mcde_dsi.c index 694372581840..ce078aa3910f 100644 --- a/drivers/gpu/drm/mcde/mcde_dsi.c +++ b/drivers/gpu/drm/mcde/mcde_dsi.c @@ -1076,7 +1076,6 @@ static int mcde_dsi_bind(struct device *dev, struct device *master, struct drm_device *drm = data; struct mcde *mcde = to_mcde(drm); struct mcde_dsi *d = dev_get_drvdata(dev); - struct device_node *child; struct drm_panel *panel = NULL; struct drm_bridge *bridge __free(drm_bridge_put) = NULL; @@ -1104,7 +1103,7 @@ static int mcde_dsi_bind(struct device *dev, struct device *master, } /* Look for a panel as a child to this node */ - for_each_available_child_of_node(dev->of_node, child) { + for_each_available_child_of_node_scoped(dev->of_node, child) { panel = of_drm_find_panel(child); if (IS_ERR(panel)) { dev_err(dev, "failed to find panel try bridge (%ld)\n", @@ -1114,15 +1113,12 @@ static int mcde_dsi_bind(struct device *dev, struct device *master, bridge = of_drm_find_and_get_bridge(child); if (!bridge) { dev_err(dev, "failed to find bridge\n"); - of_node_put(child); return -EINVAL; } } - if (panel || bridge) { - of_node_put(child); + if (panel || bridge) break; - } } if (panel) { bridge = drm_panel_bridge_add_typed(panel, -- 2.55.0