From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54476C61DD6 for ; Thu, 3 Sep 2026 02:48:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=j7makayvwVVEgOsCGADcikSN7EoYARu9kLQ80Q6eUXg=; b=n20d+WCRqGZQ4d ENno9Ti03g5ZqU97rmFySfCXC74ddHVIlApzds8KSY4l8Pk6WRgzb4IdinfrclcIksdtJ22IxE9um KCKTAFKnRWeDb5pEnmXvP7SpUAlpkMQMIUd1zHprAhDAmc/thkLE7WLuq/MUf+9MMcEOElA4TmJhd 44A5hyRxbQzQVi02+lK9Baq0hQDJEqnNdl13KnDYRaMZLJKGevbE95QUINsGnFDBcFAvxjm3wpBAy d8+NtQzflR0A0+7e2Fqd4g01lIPqPJXdhMKJPMhF+L6/YdxjDLENPnXCsvEWud6VX0I9845WgeqKF Yq5XcJY6rEhpuuieEyww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x1xVW-0000000GFDd-3eSm; Thu, 03 Sep 2026 02:48:54 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x1xVV-0000000GFDX-0Myo for linux-phy@lists.infradead.org; Thu, 03 Sep 2026 02:48:53 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id BC91340A66; Thu, 3 Sep 2026 02:48:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A9431F000E9; Thu, 3 Sep 2026 02:48:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788403732; bh=JLxLtfb/xPEr0vKGjJmgeJR+BBWnZhJN7K8XakhPQYM=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=OJ+RjBekLtl8z/D9fW4lmQNccAt0QW31Phvne9Miz5bcloA7LRxSOKUTZ/PYsW1gS 1hKkvqcgLoMnX5ZH1xEdxTPpWwafNmLM4/pZRmRgWVd47iQa7/QkhiouZS7AJzDH1n ETLPUljz1zXpJUxE+zwCumfqn+5lrEKzJdAhc4qneuVtz2EXJbj+5IQ+AUBX8lr1Dn sWW4kM86QbVsb3I2C5hVz0+2KDC5HL3Bc+DgQ9UuQDdlAuwDEdhVvet9PVhZGUMX2R mYzkR0/ZFsgT3WdFkiQrfRYI1fLkd3lVTo2fEKKs1gqCwF+xO+mPlNTj3dcDPOdc7x U5OHZZLJBayCg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 3/5] phy: cix: Add CIX Sky1 USB3 PHY driver To: "Hongliang Yang" Cc: robh@kernel.org, linux-phy@lists.infradead.org, conor+dt@kernel.org, olteanv@gmail.com, devicetree@vger.kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org In-Reply-To: <20260903023521.2064986-4-hongliang.yang@cixtech.com> References: <503e87d9-3311-413a-98c0-e02a02c4a354@kernel.org> <20260903023521.2064986-1-hongliang.yang@cixtech.com> <20260903023521.2064986-4-hongliang.yang@cixtech.com> Date: Thu, 03 Sep 2026 02:48:51 +0000 Message-Id: <20260903024852.3A9431F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg NCBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0xvd10gSW5jb3JyZWN0IGZvcm1h dCBzcGVjaWZpZXIgZm9yIHByaW50aW5nIGBkZXZpY2Vfbm9kZWAgcG9pbnRlci4KLSBbTG93XSBN aXNzaW5nIGBkZXZtX211dGV4X2luaXQoKWAgZm9yIGRldm0tYWxsb2NhdGVkIG11dGV4LgotIFtM b3ddIE1pc3NpbmcgZXhwbGljaXQgaW5jbHVzaW9uIG9mIGA8bGludXgvcHJvcGVydHkuaD5gLgot IFtMb3ddIFVudXNlZCBkYXRhIHN0cnVjdHVyZXMgYW5kIGVudW1lcmF0aW9ucyBpbiB0aGUgaGVh ZGVyIGZpbGUuCi0tCgpjb21taXQgNWNhZDQ4MjExZWI1NzU4ZjlhNDA2ODc3ODk1NDRjYjA3ODQ2 Y2I0YQpBdXRob3I6IEhvbmdsaWFuZyBZYW5nIDxob25nbGlhbmcueWFuZ0BjaXh0ZWNoLmNvbT4K CnBoeTogY2l4OiBBZGQgQ0lYIFNreTEgVVNCMyBQSFkgZHJpdmVyCgpBZGQgUEhZIGRyaXZlciBm b3IgdGhlIFVTQjMgUEhZIGZvdW5kIG9uIENJWCBTa3kxIFNvQ3MuIFRoZSBkcml2ZXIKaGFuZGxl cyBpbml0aWFsaXphdGlvbiwgcmVzZXQsIGFuZCBjbG9jayBtYW5hZ2VtZW50IGZvciB0aGUKbXVs dGktcG9ydCBVU0IzIFBIWS4KCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGh5L2NpeC9waHktY2l4 LXVzYjMuYyBiL2RyaXZlcnMvcGh5L2NpeC9waHktY2l4LXVzYjMuYwo+IG5ldyBmaWxlIG1vZGUg MTAwNjQ0Cj4gaW5kZXggMDAwMDAwMDAwMDAwMC4uMGYwNzRhZjg0ZTkwOQo+IC0tLSAvZGV2L251 bGwKPiArKysgYi9kcml2ZXJzL3BoeS9jaXgvcGh5LWNpeC11c2IzLmMKPiBAQCAtMCwwICsxLDQx MCBAQAo+ICsvLyBTUERYLUxpY2Vuc2UtSWRlbnRpZmllcjogR1BMLTIuMAo+ICsvKgo+ICsgKiBw aHkgZHJpdmVyIGZvciBjZG5fc2QwODAzX3Q3Z190eXBlYQo+ICsgKgo+ICsgKiBBdXRob3I6IEhv bmdsaWFuZyBZYW5nIDxob25nbGlhbmcueWFuZ0BjaXh0ZWNoLmNvbT4KPiArICovCj4gKwo+ICsj aW5jbHVkZSA8bGludXgvY2xrLmg+Cj4gKyNpbmNsdWRlIDxsaW51eC9pby5oPgo+ICsjaW5jbHVk ZSA8bGludXgva2VybmVsLmg+Cj4gKyNpbmNsdWRlIDxsaW51eC9tb2R1bGUuaD4KPiArI2luY2x1 ZGUgPGxpbnV4L211dGV4Lmg+Cj4gKyNpbmNsdWRlIDxsaW51eC9vZi5oPgo+ICsjaW5jbHVkZSA8 bGludXgvcGh5L3BoeS5oPgo+ICsjaW5jbHVkZSA8bGludXgvcGxhdGZvcm1fZGV2aWNlLmg+Cj4g KyNpbmNsdWRlIDxsaW51eC9yZWdtYXAuaD4KPiArI2luY2x1ZGUgPGxpbnV4L3Jlc2V0Lmg+Cj4g KyNpbmNsdWRlICJwaHktY2l4LXVzYmRwLmgiCgpbU2V2ZXJpdHk6IExvd10KU2luY2UgdGhlIGRy aXZlciB1c2VzIGRldmljZV9mb3JfZWFjaF9jaGlsZF9ub2RlX3Njb3BlZCgpLCBzaG91bGQKPGxp bnV4L3Byb3BlcnR5Lmg+IGJlIGV4cGxpY2l0bHkgaW5jbHVkZWQgaGVyZSB0byBhdm9pZCByZWx5 aW5nIG9uIGltcGxpY2l0CmRlcGVuZGVuY2llcyBmcm9tIG90aGVyIGhlYWRlcnM/CgpbIC4uLiBd Cgo+ICtzdGF0aWMgaW50IGNpeF91M3BoeV9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpw ZGV2KQo+ICt7Cj4gKwlzdHJ1Y3QgY2l4X3UzcGh5ICp1M3BoeTsKPiArCXN0cnVjdCBkZXZpY2Ug KmRldiA9ICZwZGV2LT5kZXY7Cj4gKwlzdHJ1Y3QgcGh5X3Byb3ZpZGVyICpwaHlfcHJvdmlkZXI7 Cj4gKwlzdHJ1Y3QgZGV2aWNlX25vZGUgKm5wID0gZGV2LT5vZl9ub2RlOwo+ICsJc3RydWN0IGRl dmljZV9ub2RlICpjaGlsZF9ucDsKPiArCXN0cnVjdCBwaHkgKnBoeTsKPiArCWludCByZXQ7Cj4g Kwo+ICsJdTNwaHkgPSBkZXZtX2t6YWxsb2MoZGV2LCBzaXplb2YoKnUzcGh5KSwgR0ZQX0tFUk5F TCk7Cj4gKwlpZiAoIXUzcGh5KQo+ICsJCXJldHVybiAtRU5PTUVNOwo+ICsJZGV2X3NldF9kcnZk YXRhKGRldiwgdTNwaHkpOwo+ICsJdTNwaHktPmRldiA9IGRldjsKPiArCXUzcGh5LT5jZmcgPSBk ZXZpY2VfZ2V0X21hdGNoX2RhdGEoZGV2KTsKPiArCWlmICghdTNwaHktPmNmZykgewo+ICsJCWRl dl9lcnIoZGV2LCAibm8gT0YgZGF0YSBjYW4gYmUgbWF0Y2hlZCB3aXRoICVwIG5vZGVcbiIsIG5w KTsKCltTZXZlcml0eTogTG93XQpXaWxsIHRoaXMgcHJpbnQgdGhlIHJhdyBwb2ludGVyIGFkZHJl c3MgaW5zdGVhZCBvZiB0aGUgZGV2aWNlIG5vZGUgbmFtZT8KU2luY2UgbnAgaXMgYSBkZXZpY2Vf bm9kZSBwb2ludGVyLCBzaG91bGQgdGhlICVwT0YgZm9ybWF0IHNwZWNpZmllciBiZQp1c2VkIGlu c3RlYWQ/Cgo+ICsJCXJldHVybiAtRUlOVkFMOwo+ICsJfQo+ICsJdTNwaHktPnJlc2V0ID0gZGV2 bV9yZXNldF9jb250cm9sX2dldF9leGNsdXNpdmUoZGV2LCAiY29yZSIpOwoKWyAuLi4gXQoKPiAr CXUzcGh5LT5iYXNlID0gZGV2bV9wbGF0Zm9ybV9pb3JlbWFwX3Jlc291cmNlKHBkZXYsIDApOwo+ ICsJaWYgKElTX0VSUih1M3BoeS0+YmFzZSkpCj4gKwkJcmV0dXJuIFBUUl9FUlIodTNwaHktPmJh c2UpOwo+ICsJdTNwaHktPnBoeV9yZWdtYXAgPSBkZXZtX3JlZ21hcF9pbml0KGRldiwgTlVMTCwg dTNwaHksICZjaXhfdTNwaHlfcmVnbWFwX2NmZyk7Cj4gKwlpZiAoSVNfRVJSKHUzcGh5LT5waHlf cmVnbWFwKSkgewo+ICsJCWRldl9lcnIoZGV2LCAiZmFpbGVkIHRvIHJlbWFwIHBoeSByZWdpc3Rl clxuIik7Cj4gKwkJcmV0dXJuIFBUUl9FUlIodTNwaHktPnBoeV9yZWdtYXApOwo+ICsJfQo+ICsJ bXV0ZXhfaW5pdCgmdTNwaHktPm11dGV4KTsKCltTZXZlcml0eTogTG93XQpTaW5jZSB1M3BoeSBp cyBhbGxvY2F0ZWQgdXNpbmcgZGV2bV9remFsbG9jKCksIHRoZSBtZW1vcnkgd2lsbCBiZQphdXRv bWF0aWNhbGx5IGZyZWVkIG9uIGRyaXZlciB1bmJpbmQuIFdoZW4gaW5pdGlhbGl6ZWQgd2l0aCBt dXRleF9pbml0KCksCm11dGV4X2Rlc3Ryb3koKSB3b24ndCBiZSBjYWxsZWQgYXV0b21hdGljYWxs eSwgd2hpY2ggc2tpcHMgY2xlYW51cCBzdGVwcwpleHBlY3RlZCBieSB0aGUgcmVzb3VyY2UgbWFu YWdlbWVudCBBUEkgZm9yIGRldm0tYWxsb2NhdGVkIG11dGV4ZXMuIFNob3VsZApkZXZtX211dGV4 X2luaXQoKSBiZSB1c2VkIGhlcmUgaW5zdGVhZD8KCj4gKwlkZXZpY2VfZm9yX2VhY2hfY2hpbGRf bm9kZV9zY29wZWQoZGV2LCBjaGlsZF9mbikgewo+ICsJCWNvbnN0IGNoYXIgKm5hbWUgPSBmd25v ZGVfZ2V0X25hbWUoY2hpbGRfZm4pOwoKWyAuLi4gXQoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9w aHkvY2l4L3BoeS1jaXgtdXNiZHAuaCBiL2RyaXZlcnMvcGh5L2NpeC9waHktY2l4LXVzYmRwLmgK PiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+IGluZGV4IDAwMDAwMDAwMDAwMDAuLjZlYzdlYjVjODFh YTkKPiAtLS0gL2Rldi9udWxsCj4gKysrIGIvZHJpdmVycy9waHkvY2l4L3BoeS1jaXgtdXNiZHAu aAo+IEBAIC0wLDAgKzEsMzEwIEBACgpbIC4uLiBdCgo+ICsvKiBnb3Agc3RhdHVzIGFkZHJlc3Mg Ki8KPiArI2RlZmluZSBHT1BfU1RBVFVTX0FERFJFU1MgMHg4M0UwNTAwMAo+ICsjZGVmaW5lIEdP UF9TVEFUVVNfU0laRSAweDA0Cj4gKwo+ICtzdHJ1Y3QgZ29wX3N0YXR1cyB7Cj4gKwl1bnNpZ25l ZCBjaGFyIHBoeV9zdGF0dXNbNF07Cj4gK307Cj4gKwo+ICsvKgo+ICsgKiAwOiB1c2IKPiArICog MTogMiBsYW5lIHVzYisgMiBsYW5lIGRwCj4gKyAqIDI6IHVzYiBkZXZpY2UKPiArICogMzogdXNi Mi4wICsgNCBsYW5lIGRwCj4gKyAqLwo+ICtlbnVtIHBoeV9yb2xlIHsKPiArCVVTQl9ST0xFX05P TkUsCj4gKwlVU0JfUk9MRV9IT1NULAo+ICsJVVNCX1JPTEVfREVWSUNFLAo+ICsJVVNCX1JPTEVf SE9TVF8yMCwKPiArfTsKCltTZXZlcml0eTogTG93XQpBcmUgdGhpcyBzdHJ1Y3QgYW5kIGVudW0g bmVlZGVkPyBOZWl0aGVyIGdvcF9zdGF0dXMgbm9yIHBoeV9yb2xlIGFwcGVhciB0bwpiZSB1c2Vk IGFueXdoZXJlIGluIHRoZSBwcm92aWRlZCBjb2RlLgoKPiArCj4gKyNlbmRpZgoKLS0gClNhc2hp a28gQUkgcmV2aWV3IMK3IGh0dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRjaHNldC8yMDI2MDkwMzAy MzUyMS4yMDY0OTg2LTEtaG9uZ2xpYW5nLnlhbmdAY2l4dGVjaC5jb20/cGFydD0zCgotLSAKbGlu dXgtcGh5IG1haWxpbmcgbGlzdApsaW51eC1waHlAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwczov L2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1waHkK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AC992BEC3F for ; Thu, 3 Sep 2026 02:48:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788403734; cv=none; b=HfkG5ySX878+xHFVo8C05jNieT5jhVS7CtoJM/oSbgH5Tl6YfVYgatyHzQ5NyCdIhvh6KXkoZhloUth5i3a9UJ3S0c01M76ZORcioUGHz69jSIA8x7jzFvqHsuN0WXqXZM03PQFKJFlqXFCpeVu7CsuKpp5XRFPQ/Dvi0bqRx4I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788403734; c=relaxed/simple; bh=DusOHe16A1czF5QDRBD8vfo9231kUJ002bbr7Uc5+oo=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=BEMJGQRQl+HKk87yCoAWQUQ6V75gsOmxHLw8makk2/BIqvlMTS8shrAI8qmdL46YxZTgEoSvObD46RytfOntpAa7BzboDGZi1NKs40awflsnFo2KpYglhfkNcQckedxdBpC64MxMxFHDfHPQYoRGufwtyXYGOGT5MpQnTE/L9z8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OJ+RjBek; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OJ+RjBek" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A9431F000E9; Thu, 3 Sep 2026 02:48:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788403732; bh=JLxLtfb/xPEr0vKGjJmgeJR+BBWnZhJN7K8XakhPQYM=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=OJ+RjBekLtl8z/D9fW4lmQNccAt0QW31Phvne9Miz5bcloA7LRxSOKUTZ/PYsW1gS 1hKkvqcgLoMnX5ZH1xEdxTPpWwafNmLM4/pZRmRgWVd47iQa7/QkhiouZS7AJzDH1n ETLPUljz1zXpJUxE+zwCumfqn+5lrEKzJdAhc4qneuVtz2EXJbj+5IQ+AUBX8lr1Dn sWW4kM86QbVsb3I2C5hVz0+2KDC5HL3Bc+DgQ9UuQDdlAuwDEdhVvet9PVhZGUMX2R mYzkR0/ZFsgT3WdFkiQrfRYI1fLkd3lVTo2fEKKs1gqCwF+xO+mPlNTj3dcDPOdc7x U5OHZZLJBayCg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 3/5] phy: cix: Add CIX Sky1 USB3 PHY driver Reply-To: sashiko-reviews@lists.linux.dev To: "Hongliang Yang" Cc: robh@kernel.org, linux-phy@lists.infradead.org, conor+dt@kernel.org, olteanv@gmail.com, devicetree@vger.kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org In-Reply-To: <20260903023521.2064986-4-hongliang.yang@cixtech.com> References: <503e87d9-3311-413a-98c0-e02a02c4a354@kernel.org> <20260903023521.2064986-1-hongliang.yang@cixtech.com> <20260903023521.2064986-4-hongliang.yang@cixtech.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 03 Sep 2026 02:48:51 +0000 Message-Id: <20260903024852.3A9431F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 4 potential issue(= s) to consider: - [Low] Incorrect format specifier for printing `device_node` pointer. - [Low] Missing `devm_mutex_init()` for devm-allocated mutex. - [Low] Missing explicit inclusion of ``. - [Low] Unused data structures and enumerations in the header file. -- commit 5cad48211eb5758f9a40687789544cb07846cb4a Author: Hongliang Yang phy: cix: Add CIX Sky1 USB3 PHY driver Add PHY driver for the USB3 PHY found on CIX Sky1 SoCs. The driver handles initialization, reset, and clock management for the multi-port USB3 PHY. > diff --git a/drivers/phy/cix/phy-cix-usb3.c b/drivers/phy/cix/phy-cix-usb= 3.c > new file mode 100644 > index 0000000000000..0f074af84e909 > --- /dev/null > +++ b/drivers/phy/cix/phy-cix-usb3.c > @@ -0,0 +1,410 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * phy driver for cdn_sd0803_t7g_typea > + * > + * Author: Hongliang Yang > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include "phy-cix-usbdp.h" [Severity: Low] Since the driver uses device_for_each_child_node_scoped(), should be explicitly included here to avoid relying on implicit dependencies from other headers? [ ... ] > +static int cix_u3phy_probe(struct platform_device *pdev) > +{ > + struct cix_u3phy *u3phy; > + struct device *dev =3D &pdev->dev; > + struct phy_provider *phy_provider; > + struct device_node *np =3D dev->of_node; > + struct device_node *child_np; > + struct phy *phy; > + int ret; > + > + u3phy =3D devm_kzalloc(dev, sizeof(*u3phy), GFP_KERNEL); > + if (!u3phy) > + return -ENOMEM; > + dev_set_drvdata(dev, u3phy); > + u3phy->dev =3D dev; > + u3phy->cfg =3D device_get_match_data(dev); > + if (!u3phy->cfg) { > + dev_err(dev, "no OF data can be matched with %p node\n", np); [Severity: Low] Will this print the raw pointer address instead of the device node name? Since np is a device_node pointer, should the %pOF format specifier be used instead? > + return -EINVAL; > + } > + u3phy->reset =3D devm_reset_control_get_exclusive(dev, "core"); [ ... ] > + u3phy->base =3D devm_platform_ioremap_resource(pdev, 0); > + if (IS_ERR(u3phy->base)) > + return PTR_ERR(u3phy->base); > + u3phy->phy_regmap =3D devm_regmap_init(dev, NULL, u3phy, &cix_u3phy_reg= map_cfg); > + if (IS_ERR(u3phy->phy_regmap)) { > + dev_err(dev, "failed to remap phy register\n"); > + return PTR_ERR(u3phy->phy_regmap); > + } > + mutex_init(&u3phy->mutex); [Severity: Low] Since u3phy is allocated using devm_kzalloc(), the memory will be automatically freed on driver unbind. When initialized with mutex_init(), mutex_destroy() won't be called automatically, which skips cleanup steps expected by the resource management API for devm-allocated mutexes. Should devm_mutex_init() be used here instead? > + device_for_each_child_node_scoped(dev, child_fn) { > + const char *name =3D fwnode_get_name(child_fn); [ ... ] > diff --git a/drivers/phy/cix/phy-cix-usbdp.h b/drivers/phy/cix/phy-cix-us= bdp.h > new file mode 100644 > index 0000000000000..6ec7eb5c81aa9 > --- /dev/null > +++ b/drivers/phy/cix/phy-cix-usbdp.h > @@ -0,0 +1,310 @@ [ ... ] > +/* gop status address */ > +#define GOP_STATUS_ADDRESS 0x83E05000 > +#define GOP_STATUS_SIZE 0x04 > + > +struct gop_status { > + unsigned char phy_status[4]; > +}; > + > +/* > + * 0: usb > + * 1: 2 lane usb+ 2 lane dp > + * 2: usb device > + * 3: usb2.0 + 4 lane dp > + */ > +enum phy_role { > + USB_ROLE_NONE, > + USB_ROLE_HOST, > + USB_ROLE_DEVICE, > + USB_ROLE_HOST_20, > +}; [Severity: Low] Are this struct and enum needed? Neither gop_status nor phy_role appear to be used anywhere in the provided code. > + > +#endif --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260903023521.2064= 986-1-hongliang.yang@cixtech.com?part=3D3