Re: [PATCH v4 2/2] drm/panel: simple: Add BOE DV215FHM-R01 panel

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The DISPLAY_FLAGS_DE_HIGH flag in boe_dv215fhm_r01_timing is silently ignored because it is not propagated to the panel's bus_flags.
--

commit e8dda804d95e117a2144e77d29d6c181f747ad91
Author: Vishnu Saini <vishnu.saini@oss.qualcomm.com>

drm/panel: simple: Add BOE DV215FHM-R01 panel
    
This commit adds support for the BOE DV215FHM-R01 21.5" FHD (1920x1080)
dual-channel LVDS panel in the panel-simple driver.

> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index c95964ba25a95..0b516385b2673 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1593,6 +1593,31 @@ static const struct panel_desc boe_bp101wx1_100 = {
>  	.connector_type = DRM_MODE_CONNECTOR_LVDS,
>  };
>  
> +static const struct display_timing boe_dv215fhm_r01_timing = {
> +	.pixelclock = { 148500000, 148500000, 148500000 },
> +	.hactive = { 1920, 1920, 1920 },
> +	.hfront_porch = { 88, 88, 88 },
> +	.hback_porch = { 148, 148, 148 },
> +	.hsync_len = { 44, 44, 44 },
> +	.vactive = { 1080, 1080, 1080 },
> +	.vfront_porch = { 4, 4, 4 },
> +	.vback_porch = { 36, 36, 36 },
> +	.vsync_len = { 5, 5, 5 },
> +	.flags = DISPLAY_FLAGS_DE_HIGH,
> +};
> +
> +static const struct panel_desc boe_dv215fhm_r01 = {
> +	.timings = &boe_dv215fhm_r01_timing,
> +	.num_timings = 1,
> +	.bpc = 8,
> +	.size = {
> +		.width = 476,
> +		.height = 268,
> +	},
> +	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
> +	.connector_type = DRM_MODE_CONNECTOR_LVDS,
> +};

[Severity: High]
Does this panel descriptor need to set .bus_flags = DRM_BUS_FLAG_DE_HIGH?

The display_timing structure for boe_dv215fhm_r01_timing specifies
DISPLAY_FLAGS_DE_HIGH, but this flag appears to be silently ignored by the
panel-simple framework unless it is also propagated to the panel's bus_flags.

When the boe_dv215fhm_r01 panel is probed and its modes are added via
panel_simple_get_non_edid_modes(), the connector assigns:

    connector->display_info.bus_flags = panel->desc->bus_flags;

Since .bus_flags is missing from the descriptor initialization here, it
defaults to 0. This causes the Data Enable (DE) polarity requirement to be
lost. If the controller defaults to DE low, the display might not function
correctly.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260903-b4-lvds-panel-doc-v4-0-861738a0d5de@oss.qualcomm.com?part=2