Re: [PATCH v2 30/40] scsi: ibmvscsi_tgt: use 16-bits defined sense codes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] Missing assignment of SAM_STAT_CHECK_CONDITION to scsi_status causes the constructed sense buffer to be silently ignored and a falsely successful response to be sent.
--

commit b057f4e0cc70d975ef62438361ce78cb340d3412
Author: Damien Le Moal <dlemoal@kernel.org>

scsi: ibmvscsi_tgt: use 16-bits defined sense codes

This commit refactors the IBM virtual SCSI target driver to use
scsi_set_sense_buffer() and standard enum values for sense codes. This
improves code clarity by removing hard-coded ASC/ASCQ values.

> diff --git a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
> index 61f6828007654..e2af90b6da39b 100644
> --- a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
> +++ b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
> @@ -3757,9 +3757,8 @@ static int ibmvscsis_queue_data_in(struct se_cmd *se_cmd)
>  		dev_err(&vscsi->dev, "srp_transfer_data failed: %d\n", rc);
>  		se_cmd->scsi_sense_length = 18;
>  		memset(se_cmd->sense_buffer, 0, se_cmd->scsi_sense_length);
> -		/* Logical Unit Communication Time-out asc/ascq = 0x0801 */
> -		scsi_build_sense_buffer(0, se_cmd->sense_buffer, MEDIUM_ERROR,
> -					0x08, 0x01);
> +		scsi_set_sense_buffer(0, se_cmd->sense_buffer, MEDIUM_ERROR,
> +				      LU_COMMUNICATION_TIMEOUT);
>  	}
>  

[Severity: High]
This isn't a bug introduced by this patch, but does this error path properly
set the SCSI status?

When srp_transfer_data() fails in ibmvscsis_queue_data_in(), the code builds
a sense buffer but doesn't appear to update se_cmd->scsi_status to
SAM_STAT_CHECK_CONDITION.

Because of this, does srp_build_response() evaluate rsp->status as
SAM_STAT_GOOD (0)? If so, it skips the logic that copies the sense buffer
and sends a falsely successful response without any sense data. Masking this
transfer failure could cause the initiator to consume uninitialized or stale
memory as valid read data.

>  	srp_build_response(vscsi, cmd, &len);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260903034201.112211-1-dlemoal@kernel.org?part=30