From: sashiko-bot@kernel.org
To: "Thomas Weißschuh (Schneider Electric)"
<thomas.weissschuh@linutronix.de>
Cc: linux-rtc@vger.kernel.org,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH 3/4] rtc: lib: Implement time64_to_tm() in terms of time64_to_tm()
Date: Thu, 03 Sep 2026 07:55:02 +0000 [thread overview]
Message-ID: <20260903075502.E9CBC1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260903-time-time64-to-tm-v1-3-660be972adfc@linutronix.de>
> The core timekeeping code already provides a function to convert seconds
> since the epoch to a 'struct tm'. This can be reused for a the
> 'struct rtc_time' conversion.
>
> time64_to_tm() can handle a larger range of dates. It is also
> 20% slower, but this function is not a hot-path anyways.
> On the other hand this saves ~600 bytes of .text.
>
> Signed-off-by: Thomas Weißschuh (Schneider Electric) <thomas.weissschuh@linutronix.de>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260903-time-time64-to-tm-v1-0-660be972adfc@linutronix.de?part=3
next prev parent reply other threads:[~2026-09-03 7:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 7:46 [PATCH 0/4] time: time64_to_tm() cleanups Thomas Weißschuh (Schneider Electric)
2026-09-03 7:46 ` [PATCH 1/4] time: Avoid 64-bit by 64-bit division in time64_to_tm() Thomas Weißschuh (Schneider Electric)
2026-09-03 7:50 ` sashiko-bot
2026-09-03 7:46 ` [PATCH 2/4] time: test: Avoid unnecessary divisions in time64_to_tm() test Thomas Weißschuh (Schneider Electric)
2026-09-03 7:50 ` sashiko-bot
2026-09-03 7:46 ` [PATCH 3/4] rtc: lib: Implement time64_to_tm() in terms of time64_to_tm() Thomas Weißschuh (Schneider Electric)
2026-09-03 7:55 ` sashiko-bot [this message]
2026-09-03 7:46 ` [PATCH 4/4] rtc: test: Remove test_rtc_lib.c Thomas Weißschuh (Schneider Electric)
2026-09-03 7:54 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260903075502.E9CBC1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-rtc@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=thomas.weissschuh@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.