From: sashiko-bot@kernel.org
To: liujing <liujing@cmss.chinamobile.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf script: Fix unsigned comparison against zero in print_bstack_flags()
Date: Thu, 03 Sep 2026 08:26:29 +0000 [thread overview]
Message-ID: <20260903082629.AC6A31F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260903082128.4972-3-liujing@cmss.chinamobile.com>
> From: Liu Jing <liujing@cmss.chinamobile.com>
>
> In print_bstack_flags(), the variable `pos` is declared as `size_t`
> (unsigned), making the check `pos < 0` always false. This means the
> error return from snprintf() is never detected.
>
> Fix it by changing the return type of bstack_event_str() to int and
> the type of pos to int, so that negative return values from snprintf()
> are properly checked.
>
> Signed-off-by: Liu Jing <liujing@cmss.chinamobile.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260903082128.4972-3-liujing@cmss.chinamobile.com?part=1
next prev parent reply other threads:[~2026-09-03 8:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 8:21 [PATCH] perf sched: Fix resource leak in enable_sched_schedstats() liujing
2026-09-03 8:21 ` [PATCH] perf intel-pt: Fix undefined shift in intel_pt_bip() liujing
2026-09-03 8:31 ` sashiko-bot
2026-09-08 20:58 ` Arnaldo Carvalho de Melo
2026-09-03 8:21 ` [PATCH] perf script: Fix unsigned comparison against zero in print_bstack_flags() liujing
2026-09-03 8:26 ` sashiko-bot [this message]
2026-09-03 8:21 ` [PATCH] perf arm: Fix memory leak in find_all_arm_spe_pmus() liujing
2026-09-03 8:31 ` sashiko-bot
2026-09-03 8:33 ` [PATCH] perf sched: Fix resource leak in enable_sched_schedstats() sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260903082629.AC6A31F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=liujing@cmss.chinamobile.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.