Re: [PATCH] dt-bindings: usb: Add ITE IT5271/IT5272/IT5273/IT5274 support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The schema fails to require `#address-cells` and `#size-cells` for the parent node, despite mandating child nodes with unit addresses.
- [Low] Misplaced entry in the MAINTAINERS file disrupting alphabetical order.
--

commit 837acb02e0d2d80f62a7b268e076746b70c411ef
Author: Amber Kao <ite_pd@ite.com.tw>

dt-bindings: usb: Add ITE IT5271/IT5272/IT5273/IT5274 support
    
Add device tree binding documentation for the ITE IT527x series
(IT5271, IT5272, IT5273, and IT5274) I2C-based USB Type-C Power
Delivery (PD) controllers.

> diff --git a/Documentation/devicetree/bindings/usb/ite,it5271.yaml b/Documentation/devicetree/bindings/usb/ite,it5271.yaml
> index 0000000000000..29cd7add9bde2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/ite,it5271.yaml

[ ... ]

> +patternProperties:
> +  '^connector@[01]$':
> +    $ref: /schemas/connector/usb-connector.yaml#
> +    properties:
> +      reg:
> +        maxItems: 1
> +    required:
> +      - reg
> +    unevaluatedProperties: false
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts

[Severity: Low]
Should `#address-cells` and `#size-cells` be added to this required list?

Since the schema mandates child connector nodes with unit addresses (`reg`),
device trees missing `#address-cells` and `#size-cells` in the parent node will
pass schema validation silently, even though they are structurally invalid and
will trigger `dtc` warnings (e.g., node has a unit name, but no reg or
#address-cells).

> +
> +anyOf:
> +  - required:
> +      - connector@0

[ ... ]

> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4dfc1fb14ef72..1a35242257fc8 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -13940,6 +13940,14 @@ T:	git https://gitlab.freedesktop.org/drm/misc/kernel.git
>  F:	Documentation/devicetree/bindings/display/bridge/ite,it66121.yaml
>  F:	drivers/gpu/drm/bridge/ite-it66121.c
>  
> +ITE IT5271 TYPE-C PD CONTROLLER DRIVER

[Severity: Low]
Does this new entry disrupt the alphabetical ordering of the MAINTAINERS file?

"ITE IT5271 TYPE-C PD CONTROLLER DRIVER" is currently placed after "ITE
IT66121 HDMI BRIDGE", which violates the expected alphabetical sorting.

> +M:	Amber Kao <amber.kao@ite.com.tw>
> +M:	ITE PD TEAM <ite_pd@ite.com.tw>
> +R:	Yaode Fang <Yaode.Fang@ite.com.tw>
> +L:	linux-usb@vger.kernel.org
> +S:	Maintained
> +F:	Documentation/devicetree/bindings/usb/ite,it5271.yaml
> +

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260903-it5271-binding-v1-1-1abd2c8cea85@ite.com.tw?part=1