All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Muhammad Usama Anjum" <usama.anjum@arm.com>
Cc: damon@lists.linux.dev, linux-trace-kernel@vger.kernel.org,
	linux-perf-users@vger.kernel.org,
	dri-devel@lists.freedesktop.org, bpf@vger.kernel.org,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 1/8] mm: introduce hw_pte_t for PTE table storage
Date: Thu, 03 Sep 2026 10:36:07 +0000	[thread overview]
Message-ID: <20260903103607.B9ACF1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260903103002.1091859-2-usama.anjum@arm.com>

> pte_t is used both for software PTE values and for entries stored in a PTE
> table, so pte_t * does not distinguish a pointer to a software PTE
> value from a pointer to table storage.
> 
> Introduce hw_pte_t as the generic name for a PTE table element. Define it
> as a macro alias of pte_t by default. When an architecture selects
> ARCH_HAS_HW_PTE_T, define it as a structure containing a pte_t instead.
> This preserves the representation while allowing converted architectures
> to enforce the distinction at compile time.
> 
> Name the generic wrapper structure __hw_pte_t so architectures can
> forward-declare it when pgtable_t must be defined before the generic
> hw_pte_t typedef is visible. This avoids header-order dependencies.
> 
> Keep the C type definitions behind an __ASSEMBLY__ check because
> architecture assembly sources can include this header indirectly. Include
> asm/page.h so consumers such as linux/vmalloc.h retain the page definitions
> they previously obtained from that header.
> 
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@arm.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260903103002.1091859-1-usama.anjum@arm.com?part=1


  reply	other threads:[~2026-09-03 10:36 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-03 10:29 [PATCH v2 0/8] mm: distinguish PTE table storage from PTE values Muhammad Usama Anjum
2026-09-03 10:29 ` [PATCH v2 1/8] mm: introduce hw_pte_t for PTE table storage Muhammad Usama Anjum
2026-09-03 10:36   ` sashiko-bot [this message]
2026-09-11 17:00   ` David Hildenbrand (Arm)
2026-09-03 10:29 ` [PATCH v2 2/8] mm: rename pointers to software PTE values as ptentp Muhammad Usama Anjum
2026-09-03 10:35   ` sashiko-bot
2026-09-11 17:01   ` David Hildenbrand (Arm)
2026-09-03 10:29 ` [PATCH v2 3/8] mm: use hw_pte_t for generic PTE table storage Muhammad Usama Anjum
2026-09-03 10:48   ` sashiko-bot
2026-09-11 17:09   ` David Hildenbrand (Arm)
2026-09-03 10:29 ` [PATCH v2 4/8] mm: convert PTE table entries in ptep_get() Muhammad Usama Anjum
2026-09-03 10:45   ` sashiko-bot
2026-09-03 10:29 ` [PATCH v2 5/8] mm: convert PTE table entry to pte Muhammad Usama Anjum
2026-09-03 10:40   ` sashiko-bot
2026-09-03 10:29 ` [PATCH v2 6/8] mm/kasan: use hw_pte_t for the early shadow PTE table Muhammad Usama Anjum
2026-09-03 10:36   ` sashiko-bot
2026-09-03 10:29 ` [PATCH v2 7/8] drm/i915: use hw_pte_t for PTE range callbacks Muhammad Usama Anjum
2026-09-03 10:36   ` sashiko-bot
2026-09-03 10:30 ` [PATCH v2 8/8] xen: " Muhammad Usama Anjum
2026-09-03 10:43   ` sashiko-bot
2026-09-03 11:36 ` ✗ Fi.CI.BUILD: failure for mm: distinguish PTE table storage from PTE values (rev4) Patchwork
2026-09-11 16:55 ` [PATCH v2 0/8] mm: distinguish PTE table storage from PTE values David Hildenbrand (Arm)
2026-09-11 16:59 ` David Hildenbrand (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260903103607.B9ACF1F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=damon@lists.linux.dev \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=usama.anjum@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.