From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1FA84E2375 for ; Thu, 3 Sep 2026 15:38:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788449929; cv=none; b=P+qYHDaJgtD4HGlu39FR2T9kkiHS6YCK01Tjoh3fMVRwm9XvQlnaf/sS8ZaV4xw3275g59ELAtgX3lBMcbGaq8gJKMWcaoTTYkqVmIsYVUf9iCS4QAiL0LONeIT6olb9gsY/eUHzr8nvzYPTstmeBazUwtrYFlQVj11R2YYqZAo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788449929; c=relaxed/simple; bh=i2SqzLst+IK4eZO466/Kc/t4nId4MckYxEGDEDlm3Zc=; h=Subject:To:Cc:From:Date:Message-ID:MIME-Version:Content-Type; b=nqZqP923dNjV3/epjPUugZlODv0wNDxIHNlkGQVuOtJ0m78C8qGT90FXpE3iD6xze7hT+JfFKtasIxLz1rt3mgQZFDpseNnC2/vPuPiBqb596fnYapmRGhmEUcefjcTNDnLoP0i485dVUYWvLVYN7k4kcez78sVhWmUzwXzDpJE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=F36M5bTz; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="F36M5bTz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0190E1F000E9; Thu, 3 Sep 2026 15:38:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1788449927; bh=Zx46DkR8TIN6Op6NO8eLXdwAyeix1qzWqDkdFYOhX2E=; h=Subject:To:Cc:From:Date; b=F36M5bTzwCPZmrIa1ClLie9A4DJQo9oHY/78HZ/RhkFjmVE/uQZGAhHJHsylZeS+i 8z9gaEx0RFqpHrQGmOT3RIkGCHNHRZdHuLkiKenpPP0kbhZrsCCtDvYmwGA06FLsQM 1FwwCT0TqpxqrtkRtiAhpabqzvCemLcd5hdBJ++M= Subject: FAILED: patch "[PATCH] net/smc: stop killed, freed and out_of_sync sharing a byte" failed to apply to 6.12-stable tree To: hidayath@linux.ibm.com,horms@kernel.org,kuba@kernel.org,mjambigi@linux.ibm.com Cc: From: Date: Thu, 03 Sep 2026 17:10:12 +0200 Message-ID: <2026090312-corporal-discover-f40c@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit The patch below does not apply to the 6.12-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to . To reproduce the conflict and resubmit, you may use the following commands: git fetch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/ linux-6.12.y git checkout FETCH_HEAD git cherry-pick -x db51a8658c11a82432b64999519a269c3aabb447 # git commit -s git send-email --to '' --in-reply-to '2026090312-corporal-discover-f40c@gregkh' --subject-prefix 'PATCH 6.12.y' 'HEAD^..' Possible dependencies: thanks, greg k-h ------------------ original commit in Linus's tree ------------------ >From db51a8658c11a82432b64999519a269c3aabb447 Mon Sep 17 00:00:00 2001 From: Hidayath Khan Date: Thu, 20 Aug 2026 09:46:41 +0200 Subject: [PATCH] net/smc: stop killed, freed and out_of_sync sharing a byte The three connection state flags are single-bit bitfields, so they occupy one byte of struct smc_connection and every store to one is a read-modify-write of the other two: u8 killed : 1; u8 freed : 1; u8 out_of_sync : 1; They are not written under a common lock. smc_cdc_msg_validate() sets out_of_sync from the receive tasklet, while smc_conn_kill() sets killed from process context under lock_sock(), and the receive path does not defer to the backlog when the socket is owned -- smc_cdc_msg_recv() takes only bh_lock_sock(). Give each flag its own byte so a store no longer touches its neighbours. All readers test them as booleans and are unchanged. struct smc_connection grows by two bytes. Fixes: b286a0651e44 ("net/smc: handle incoming CDC validation message") Cc: stable@vger.kernel.org Reviewed-by: Mahanta Jambigi Signed-off-by: Hidayath Khan Reviewed-by: Simon Horman Link: https://patch.msgid.link/20260820074642.966856-2-hidayath@linux.ibm.com Signed-off-by: Jakub Kicinski diff --git a/net/smc/smc.h b/net/smc/smc.h index 52145df83f6e..427b6d63b993 100644 --- a/net/smc/smc.h +++ b/net/smc/smc.h @@ -277,9 +277,9 @@ struct smc_connection { * 0 for SMC-R, 32 for SMC-D */ u64 peer_token; /* SMC-D token of peer */ - u8 killed : 1; /* abnormal termination */ - u8 freed : 1; /* normal termination */ - u8 out_of_sync : 1; /* out of sync with peer */ + u8 killed; /* abnormal termination */ + u8 freed; /* normal termination */ + u8 out_of_sync; /* out of sync with peer */ }; struct smc_sock { /* smc sock container */