From: Aleksei Sviridkin <f@lex.la>
To: "Th\u00e9o Lebrun" <theo.lebrun@bootlin.com>
Cc: Conor Dooley <conor.dooley@microchip.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Russell King <linux@armlinux.org.uk>,
Vineeth Karumanchi <vineeth.karumanchi@amd.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH net v2 0/2] net: macb: fix the link speed the taprio setup reads
Date: Thu, 3 Sep 2026 12:36:50 +0000 [thread overview]
Message-ID: <20260903123652.23900-1-f@lex.la> (raw)
Two small fixes in macb_taprio_setup_replace(), both in how it obtains
the link speed it scales the schedule with.
The first: it hands phylink_ethtool_ksettings_get() a stack variable
it never zeroed, while phylink fills only what the link mode provides
and even reads one field back from the caller. The second: the speed
check is written as "<= 0" on a u32, so SPEED_UNKNOWN passes it and
turns into a 1 ns hardware limit that every entry then exceeds.
Compile-tested against net; the driver has no test surface, and no
macb board here.
---
v2: both commit messages rewritten to name the uninitialised-memory
case first and the link-down case as the one that happens; the
grown declaration keeps reverse xmas tree order; the error text is
"Invalid speed %d, link-down?" (Théo Lebrun). ethtool_validate_speed()
was considered for the check and does not fit: it accepts
SPEED_UNKNOWN by definition, which is exactly the value patch 2
rejects (Andrew Lunn).
https://lore.kernel.org/netdev/20260902080528.2211468-1-f@lex.la/
Aleksei Sviridkin (2):
net: macb: zero the link settings taprio reads back
net: macb: reject an unknown link speed in the taprio setup
drivers/net/ethernet/cadence/macb_main.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--
2.53.0
next reply other threads:[~2026-09-03 12:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 12:36 Aleksei Sviridkin [this message]
2026-09-03 12:36 ` [PATCH net v2 1/2] net: macb: zero the link settings taprio reads back Aleksei Sviridkin
2026-09-08 9:44 ` Paolo Abeni
2026-09-08 15:32 ` Aleksei Sviridkin
2026-09-08 17:18 ` Paolo Abeni
2026-09-03 12:36 ` [PATCH net v2 2/2] net: macb: reject an unknown link speed in the taprio setup Aleksei Sviridkin
2026-09-08 10:00 ` [PATCH net v2 0/2] net: macb: fix the link speed the taprio setup reads patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260903123652.23900-1-f@lex.la \
--to=f@lex.la \
--cc=andrew+netdev@lunn.ch \
--cc=conor.dooley@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=theo.lebrun@bootlin.com \
--cc=vineeth.karumanchi@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.