From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28FC3C61DD3 for ; Thu, 3 Sep 2026 13:44:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CB98B10F5EE; Thu, 3 Sep 2026 13:44:18 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="DRG3yNha"; dkim-atps=neutral Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8989110F5D3 for ; Thu, 3 Sep 2026 13:44:15 +0000 (UTC) Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-47f96c5b722so1730419f8f.0 for ; Thu, 03 Sep 2026 06:44:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788443054; x=1789047854; darn=lists.freedesktop.org; h=content-transfer-encoding:reply-to:content-type:mime-version :references:in-reply-to:message-id:date:subject:to:from:from:to:cc :subject:date:message-id:reply-to:content-type; bh=CD9a3ia2fXGSFrB7/OAMwjwWKzwE2gfTckbIpnOOYNQ=; b=DRG3yNha2Lh2s1MQ0G//mspKmuh9XxHUwO6YTCCOwKeuUF8MF9nztV5MvTHqu11sGY M/ebI//UTZcohkk66YFE+NrVcJO9ZvKk+/Vr+lorU/hQr6TqfHzrcNnGfyWb21d49Xjl OLfNMjz3ZVPNXkzA9qYziCPfwkVqsK2Xrqh4LqjsoZDABgFoFTE2qrxT7WEhSUCEpOs0 TnBVppI0jza5ykcN5N8dfDmp9Wdkg7YzTj0Yc6d0tbOF3rTadkoS3a1UXB1+oBy2Y0bJ pFEmYC7orixKSBWXEB8ElTg8bQoYb3iloHyRxSTdsgjRVBWV8nD++6SlU2KzbiRs2dak AWgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788443054; x=1789047854; h=content-transfer-encoding:reply-to:content-type:mime-version :references:in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=CD9a3ia2fXGSFrB7/OAMwjwWKzwE2gfTckbIpnOOYNQ=; b=aZP8MTXuMRbCz5T3OlxJrQr7OjxlPju1PP4FgPT3EuBNts8l0NQprsiOV40hcbqLYR keu0FEgPw4M6l6N3ymjQLqI03AkH3Nok9HO006DUgoI6VubvCBGu/piFw/LO6sBb6CFd 2vU53/0ap4N03lbeWGhuXOBHm4phI06tgYk7puInCumWwmW7A9mgJlh1hNsq76AMUmXO Ae08Ud9em3cG6MUFJhYYYI7+I5Ko7VimMm/f913sqr0IupG1cSkHynFtzaL9/ZjBNoGS eu4Rqd4PYHxiAsRJ7OnChRw7yzn8XvtmJW/v9c9a9hSwyFkyoznguk6eC876//+RMQnA KkXA== X-Forwarded-Encrypted: i=1; AKwUvBxOZet5xRQyKLMMtxSCz7Q0MxJsOPYNukIPI6Yv8w3f4QdKnqtHj4rXI0QIIIw9nfiCvG4oCRiHkw==@lists.freedesktop.org X-Gm-Message-State: AFuF++mYT2lM0M8KApwZOQykOl5dqJlUB01yyGQpMUkoNRmMHRELd/k1 OJGVVTUxKVVkf7zli18eCCVm6482LDACypXjqtNX/x/VcOvw4FchqbQN X-Gm-Gg: AYBFou1cD5p091gsnrx6BGICgEJZXUiWZLOrJF73cWmen8YDR8tbU+BvAtwQTpywKIJ W5cSPB5FLkBFqNt0EnB2QOR0mFdchsFjZVsPLuEzQIdS4zwjkI0LGTF/4IZkuOMR6jLtSxfDuqd 2Le+JINi7kmglW/k5X+DbCK+v7pA/4/NfTrGoVmQ46OGpR+FBUJWyIeGdAgD7fvjzefj4atdTJL SnFIybmoaoNpXmYpd/prbmhyh7arfbb87HMzitEVOoskYeQVh+xrtDtM8iN1AKjuxDMHoPGC1Dg TgckHR5NPbqLjwT5JX+UpydSzgHU59AXgU39kp8e7wvcvEr0wuErJGQwtxjj729BcAMyc7Sa/Nx XNwgNZ9/HQnbXWCziV7aPhVsZ4+tR1bD3zBXwzHdukT7+JsD0yGt1++AlqYwiR5nFjJbW5aebfp fpiOT9bzLk1SaKAcTJULRRW/+C9wNnmuieukWaAEImx2iDb7MbHtOtTUPt6lVFhtAaT4yF7NNZi w== X-Received: by 2002:adf:e008:0:20b0:485:7ca5:b870 with SMTP id ffacd0b85a97d-4857ca5b8acmr12689972f8f.4.1788443053873; Thu, 03 Sep 2026 06:44:13 -0700 (PDT) Received: from able.fritz.box ([2a00:e180:15d9:4700:e712:9f38:603a:54e4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48448e736a6sm13597080f8f.5.2026.09.03.06.44.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2026 06:44:13 -0700 (PDT) From: "=?UTF-8?q?Christian=20K=C3=B6nig?=" X-Google-Original-From: =?UTF-8?q?Christian=20K=C3=B6nig?= To: thomas.hellstrom@linux.intel.com, dakr@kernel.org, ecourtney@nvidia.com, matthew.brost@intel.com, nat@pixelcluster.dev, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, amd-gfx@lists.freedesktop.org Subject: [PATCH 03/11] dma-buf/tests: Convert st-dma-resv tests to use dma_resv_alloc v2 Date: Thu, 3 Sep 2026 15:27:58 +0200 Message-ID: <20260903134408.105317-4-christian.koenig@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260903134408.105317-1-christian.koenig@amd.com> References: <20260903134408.105317-1-christian.koenig@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: christian.koenig@amd.com Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Update all test cases in st-dma-resv.c to use the new dma_resv_alloc() API instead of stack-allocating dma_resv objects. This demonstrates the proper usage of the new allocation and reference counting interface. All five test functions now: - Use dma_resv_alloc() to allocate objects - Check for allocation failure with KUNIT_ASSERT_NOT_NULL - Clean up with dma_resv_put() which handles freeing This change also provides better test coverage for the reference counting implementation. v2: add proper error handling when dma_resv_alloc() fails Signed-off-by: Christian König Assisted-by: Claude:Sonnet 4 --- drivers/dma-buf/st-dma-resv.c | 102 +++++++++++++++++++++------------- 1 file changed, 62 insertions(+), 40 deletions(-) diff --git a/drivers/dma-buf/st-dma-resv.c b/drivers/dma-buf/st-dma-resv.c index 2c43d2d2b016..48c158cc5011 100644 --- a/drivers/dma-buf/st-dma-resv.c +++ b/drivers/dma-buf/st-dma-resv.c @@ -41,7 +41,7 @@ static struct dma_fence *alloc_fence(void) static void test_sanitycheck(struct kunit *test) { - struct dma_resv resv; + struct dma_resv *resv; struct dma_fence *f; int r; @@ -53,20 +53,22 @@ static void test_sanitycheck(struct kunit *test) dma_fence_signal(f); dma_fence_put(f); - dma_resv_init(&resv); - r = dma_resv_lock(&resv, NULL); + resv = dma_resv_alloc(); + KUNIT_ASSERT_NOT_NULL(test, resv); + + r = dma_resv_lock(resv, NULL); if (r) KUNIT_FAIL(test, "Resv locking failed\n"); else - dma_resv_unlock(&resv); - dma_resv_put(&resv); + dma_resv_unlock(resv); + dma_resv_put(resv); } static void test_signaling(struct kunit *test) { const struct dma_resv_usage_param *param = test->param_value; enum dma_resv_usage usage = param->usage; - struct dma_resv resv; + struct dma_resv *resv; struct dma_fence *f; int r; @@ -75,33 +77,38 @@ static void test_signaling(struct kunit *test) dma_fence_enable_signaling(f); - dma_resv_init(&resv); - r = dma_resv_lock(&resv, NULL); + resv = dma_resv_alloc(); + if (!resv) { + KUNIT_FAIL(test, "Resv allocation failed"); + goto err_free; + } + + r = dma_resv_lock(resv, NULL); if (r) { KUNIT_FAIL(test, "Resv locking failed"); goto err_free; } - r = dma_resv_reserve_fences(&resv, 1); + r = dma_resv_reserve_fences(resv, 1); if (r) { KUNIT_FAIL(test, "Resv shared slot allocation failed"); goto err_unlock; } - dma_resv_add_fence(&resv, f, usage); - if (dma_resv_test_signaled(&resv, usage)) { + dma_resv_add_fence(resv, f, usage); + if (dma_resv_test_signaled(resv, usage)) { KUNIT_FAIL(test, "Resv unexpectedly signaled"); goto err_unlock; } dma_fence_signal(f); - if (!dma_resv_test_signaled(&resv, usage)) { + if (!dma_resv_test_signaled(resv, usage)) { KUNIT_FAIL(test, "Resv not reporting signaled"); goto err_unlock; } err_unlock: - dma_resv_unlock(&resv); + dma_resv_unlock(resv); err_free: - dma_resv_put(&resv); + dma_resv_put(resv); dma_fence_put(f); } @@ -111,7 +118,7 @@ static void test_for_each(struct kunit *test) enum dma_resv_usage usage = param->usage; struct dma_resv_iter cursor; struct dma_fence *f, *fence; - struct dma_resv resv; + struct dma_resv *resv; int r; f = alloc_fence(); @@ -119,23 +126,28 @@ static void test_for_each(struct kunit *test) dma_fence_enable_signaling(f); - dma_resv_init(&resv); - r = dma_resv_lock(&resv, NULL); + resv = dma_resv_alloc(); + if (!resv) { + KUNIT_FAIL(test, "Resv allocation failed"); + goto err_free; + } + + r = dma_resv_lock(resv, NULL); if (r) { KUNIT_FAIL(test, "Resv locking failed"); goto err_free; } - r = dma_resv_reserve_fences(&resv, 1); + r = dma_resv_reserve_fences(resv, 1); if (r) { KUNIT_FAIL(test, "Resv shared slot allocation failed"); goto err_unlock; } - dma_resv_add_fence(&resv, f, usage); + dma_resv_add_fence(resv, f, usage); r = -ENOENT; - dma_resv_for_each_fence(&cursor, &resv, usage, fence) { + dma_resv_for_each_fence(&cursor, resv, usage, fence) { if (!r) { KUNIT_FAIL(test, "More than one fence found"); goto err_unlock; @@ -158,9 +170,9 @@ static void test_for_each(struct kunit *test) } dma_fence_signal(f); err_unlock: - dma_resv_unlock(&resv); + dma_resv_unlock(resv); err_free: - dma_resv_put(&resv); + dma_resv_put(resv); dma_fence_put(f); } @@ -170,7 +182,7 @@ static void test_for_each_unlocked(struct kunit *test) enum dma_resv_usage usage = param->usage; struct dma_resv_iter cursor; struct dma_fence *f, *fence; - struct dma_resv resv; + struct dma_resv *resv; int r; f = alloc_fence(); @@ -178,25 +190,30 @@ static void test_for_each_unlocked(struct kunit *test) dma_fence_enable_signaling(f); - dma_resv_init(&resv); - r = dma_resv_lock(&resv, NULL); + resv = dma_resv_alloc(); + if (!resv) { + KUNIT_FAIL(test, "Resv allocation failed"); + goto err_free; + } + + r = dma_resv_lock(resv, NULL); if (r) { KUNIT_FAIL(test, "Resv locking failed"); goto err_free; } - r = dma_resv_reserve_fences(&resv, 1); + r = dma_resv_reserve_fences(resv, 1); if (r) { KUNIT_FAIL(test, "Resv shared slot allocation failed"); - dma_resv_unlock(&resv); + dma_resv_unlock(resv); goto err_free; } - dma_resv_add_fence(&resv, f, usage); - dma_resv_unlock(&resv); + dma_resv_add_fence(resv, f, usage); + dma_resv_unlock(resv); r = -ENOENT; - dma_resv_iter_begin(&cursor, &resv, usage); + dma_resv_iter_begin(&cursor, resv, usage); dma_resv_for_each_fence_unlocked(&cursor, fence) { if (!r) { KUNIT_FAIL(test, "More than one fence found"); @@ -231,7 +248,7 @@ static void test_for_each_unlocked(struct kunit *test) dma_resv_iter_end(&cursor); dma_fence_signal(f); err_free: - dma_resv_put(&resv); + dma_resv_put(resv); dma_fence_put(f); } @@ -240,7 +257,7 @@ static void test_get_fences(struct kunit *test) const struct dma_resv_usage_param *param = test->param_value; enum dma_resv_usage usage = param->usage; struct dma_fence *f, **fences = NULL; - struct dma_resv resv; + struct dma_resv *resv; int r, i; f = alloc_fence(); @@ -248,24 +265,29 @@ static void test_get_fences(struct kunit *test) dma_fence_enable_signaling(f); - dma_resv_init(&resv); - r = dma_resv_lock(&resv, NULL); + resv = dma_resv_alloc(); + if (!resv) { + KUNIT_FAIL(test, "Resv allocation failed"); + goto err_resv; + } + + r = dma_resv_lock(resv, NULL); if (r) { KUNIT_FAIL(test, "Resv locking failed"); goto err_resv; } - r = dma_resv_reserve_fences(&resv, 1); + r = dma_resv_reserve_fences(resv, 1); if (r) { KUNIT_FAIL(test, "Resv shared slot allocation failed"); - dma_resv_unlock(&resv); + dma_resv_unlock(resv); goto err_resv; } - dma_resv_add_fence(&resv, f, usage); - dma_resv_unlock(&resv); + dma_resv_add_fence(resv, f, usage); + dma_resv_unlock(resv); - r = dma_resv_get_fences(&resv, usage, &i, &fences); + r = dma_resv_get_fences(resv, usage, &i, &fences); if (r) { KUNIT_FAIL(test, "get_fences failed"); goto err_free; @@ -282,7 +304,7 @@ static void test_get_fences(struct kunit *test) dma_fence_put(fences[i]); kfree(fences); err_resv: - dma_resv_put(&resv); + dma_resv_put(resv); dma_fence_put(f); } -- 2.43.0