All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, david.marchand@redhat.com,
	Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: Re: [PATCH 1/1] test/memcpy: reduce duration
Date: Thu, 3 Sep 2026 14:26:51 -0700	[thread overview]
Message-ID: <20260903142651.156703c9@phoenix.local> (raw)
In-Reply-To: <20251031114310.4062899-1-thomas@monjalon.net>

On Fri, 31 Oct 2025 12:43:09 +0100
Thomas Monjalon <thomas@monjalon.net> wrote:

> When running on limited platforms like GitHub Actions,
> the functional unit test "memcpy_autotest"
> may hit a timeout, especially when running with UBSan.
> 
> This change skips testing some alignment offsets (from 0 to 31).
> It will test only every 3-byte offsets for the source buffer,
> and every 2-byte offsets for the destination buffer.
> So it is supposed to be 6x faster with a reasonably smaller coverage.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  app/test/test_memcpy.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/app/test/test_memcpy.c b/app/test/test_memcpy.c
> index 802dc4631b..ea9e76e9ad 100644
> --- a/app/test/test_memcpy.c
> +++ b/app/test/test_memcpy.c
> @@ -105,8 +105,8 @@ func_test(void)
>  	unsigned int off_src, off_dst, i;
>  	int ret;
>  
> -	for (off_src = 0; off_src < ALIGNMENT_UNIT; off_src++) {
> -		for (off_dst = 0; off_dst < ALIGNMENT_UNIT; off_dst++) {
> +	for (off_src = 0; off_src < ALIGNMENT_UNIT; off_src += 3) {
> +		for (off_dst = 0; off_dst < ALIGNMENT_UNIT; off_dst += 2) {
>  			for (i = 0; i < RTE_DIM(buf_sizes); i++) {
>  				ret = test_single_memcpy(off_src, off_dst,
>  				                         buf_sizes[i]);

This was fixed by later patch.

commit bc15681021d5588072f0635ccb9937d127c64b3d
Author: Stephen Hemminger <stephen@networkplumber.org>
Date:   Thu Feb 26 08:48:43 2026 -0800

    test/memcpy: reduce alignment offset coverage
    
    The memcpy test sweeps all 32x32 src/dst alignment offset pairs which
    causes it to timeout on slow emulated 32-bit build environments [1].
    
    Replace with a curated set of 7 offsets {0, 1, 7, 15, 16, 17, 31}
    that cover the interesting alignment boundaries. This reduces the
    iterations from 38912 to 1862 while covering the same code paths.
    
    [1] https://build.opensuse.org/package/live_build_log/home:bluca:dpdk/dpdk/Debian_Testing/i586
    
    Reported-by: Luca Boccassi <bluca@debian.org>
    Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

      parent reply	other threads:[~2026-09-03 21:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-31 11:43 [PATCH 1/1] test/memcpy: reduce duration Thomas Monjalon
2025-10-31 11:48 ` Morten Brørup
2026-09-03 21:26 ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260903142651.156703c9@phoenix.local \
    --to=stephen@networkplumber.org \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=roretzla@linux.microsoft.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.