Re: [PATCH v2 3/7] dt-bindings: usb: Add qcom,sa8255p-dwc3 for firmware-managed resources

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The 'dma-coherent' property is missing from the binding, preventing it from being used in device trees.
- [Low] The 'interrupt-names' property lacks item constraints (e.g., 'items' or 'enum' lists), allowing arbitrary strings (like typos) to pass validation.
--

commit 5d3262b4959573620da7ce43d432ab2890209041
Author: Faisal Hassan <faisal.hassan@oss.qualcomm.com>

dt-bindings: usb: Add qcom,sa8255p-dwc3 for firmware-managed resources

This commit adds a new device tree binding for the USB controller on the
Qualcomm SA8255P automotive SoC. It specifies that platform resources
such as clocks and interconnects are abstracted and managed collectively by
firmware through two power domains.

> diff --git a/Documentation/devicetree/bindings/usb/qcom,sa8255p-dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,sa8255p-dwc3.yaml
> new file mode 100644
> index 0000000000000..c6db7bcf4981e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/qcom,sa8255p-dwc3.yaml

[ ... ]

> +  interrupts:
> +    minItems: 1
> +    maxItems: 6
> +
> +  interrupt-names:
> +    minItems: 1
> +    maxItems: 6

[Severity: Low]
Does interrupt-names need an items list or enum to constrain the exact string
names?

Without an explicit list, the schema will accept any arbitrary strings, which
prevents dtbs_check from catching typos during validation.

[ ... ]

> +allOf:
> +  - $ref: snps,dwc3-common.yaml#
> +
> +unevaluatedProperties: false

[Severity: Medium]
Since unevaluatedProperties is false, does dma-coherent need to be explicitly
defined in this binding?

Because dma-coherent is omitted here and in the referenced
snps,dwc3-common.yaml, adding it to a device tree will cause dtbs_check
validation to fail.

If device tree authors omit the property to appease the validator, could the
kernel fall back to non-coherent DMA mappings, resulting in unnecessary cache
maintenance overhead and a performance regression on coherent hardware?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260903153827.3463313-1-faisal.hassan@oss.qualcomm.com?part=3