From: Tom Rini <trini@konsulko.com>
To: Raymond Mao <raymondmaoca@gmail.com>
Cc: Philippe Reynes <philippe.reynes@softathome.com>,
marko.makela@iki.fi, jonny.green@keytechinc.com,
simon.glass@canonical.com, u-boot@lists.u-boot-project.org,
Simon Glass <sjg@chromium.org>
Subject: Re: [PATCH v9 05/15] drivers: crypto: add software ecdsa support
Date: Thu, 3 Sep 2026 12:33:23 -0600 [thread overview]
Message-ID: <20260903183323.GK1764417@bill-the-cat> (raw)
In-Reply-To: <CAMDkj5yMzQJLPsGrbLHDcpoYK1no2etBNTN3htetmNc9E0wdnA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1915 bytes --]
On Thu, Sep 03, 2026 at 11:33:01AM -0400, Raymond Mao wrote:
> Hi Philippe
>
> On Thu, Sep 3, 2026 at 10:32 AM Raymond Mao <raymondmaoca@gmail.com> wrote:
> >
> > Hi Philippe,
> >
> > On Thu, Sep 3, 2026 at 4:17 AM Philippe Reynes
> > <philippe.reynes@softathome.com> wrote:
> > >
> > > Add a software ecdsa driver so it is
> > > now possible to use ecdsa signature on
> > > board without ecdsa hardware support.
> > >
> > > Reviewed-by: Raymond Mao <raymondmaoca@gmail.com>
> > > Reviewed-by: Simon Glass <sjg@chromium.org>
> > > Signed-off-by: Philippe Reynes <philippe.reynes@softathome.com>
> > > ---
> > > v2:
> > > - no change
> > > v3:
> > > - add depends on ECDSA_VERIFY to ECDSA_SW
> > > - change sw_ecdsa_verify to ecdsa_hash_verify
> > > - v4
> > > - use ECDSA_MBEDTLS to build the driver
> > > - clean include (change order)
> > > v5:
> > > - use $(PHASE_) in the Makefile for the driver
> > > v6:
> > > - remove include u-boot/ecdsa.h from ecdsa-sw.c
> > > v7:
> > > - no change
> > > v8:
> > > - no change
> > > v9:
> > > - no change
> > >
> > > drivers/crypto/Makefile | 1 +
> > > drivers/crypto/ecdsa/Makefile | 6 ++++++
> > > drivers/crypto/ecdsa/ecdsa-sw.c | 32 ++++++++++++++++++++++++++++++++
> > > 3 files changed, 39 insertions(+)
> > > create mode 100644 drivers/crypto/ecdsa/Makefile
> > > create mode 100644 drivers/crypto/ecdsa/ecdsa-sw.c
> > >
> >
> > Reviewed-by: Raymond Mao <raymondmaoca@gmail.com>
> >
>
> Sorry, there is a new line at the end of the file. Please apply my tag
> with this fixed.
>
> Applying: drivers: crypto: add software ecdsa support
> .git/rebase-apply/patch:89: new blank line at EOF.
> +
> warning: 1 line adds whitespace errors.
If there's nothing else to do for the series, you can fix that up when
applying. A v10 for just a spacing issue is a little excessive.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-09-03 18:33 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 8:16 [PATCH v9 00/15] add software ecdsa support Philippe Reynes
2026-09-03 8:16 ` [PATCH v9 01/15] ecdsa: fix support of secp521r1 Philippe Reynes
2026-09-03 14:30 ` Raymond Mao
2026-09-03 8:16 ` [PATCH v9 02/15] mbedtls: enable support of ecc Philippe Reynes
2026-09-03 14:31 ` Raymond Mao
2026-09-03 8:16 ` [PATCH v9 03/15] ecdsa: initial support of ecdsa using mbedtls Philippe Reynes
2026-09-03 14:31 ` Raymond Mao
2026-09-03 8:16 ` [PATCH v9 04/15] test: lib: ecdsa: add initial test Philippe Reynes
2026-09-03 14:32 ` Raymond Mao
2026-09-03 8:16 ` [PATCH v9 05/15] drivers: crypto: add software ecdsa support Philippe Reynes
2026-09-03 14:32 ` Raymond Mao
2026-09-03 15:33 ` Raymond Mao
2026-09-03 18:33 ` Tom Rini [this message]
2026-09-03 8:16 ` [PATCH v9 06/15] test: dm: ecdsa.c: clean this test as software ecdsa is now implemented Philippe Reynes
2026-09-03 14:33 ` Raymond Mao
2026-09-03 8:16 ` [PATCH v9 07/15] test: py: vboot: prepare integration test for ecdsa Philippe Reynes
2026-09-03 15:42 ` Raymond Mao
2026-09-03 8:16 ` [PATCH v9 08/15] test: vboot: add " Philippe Reynes
2026-09-03 15:43 ` Raymond Mao
2026-09-03 8:16 ` [PATCH v9 09/15] tools: fit_image_setup_sig: set required_keynode to -1 Philippe Reynes
2026-09-03 14:34 ` Raymond Mao
2026-09-03 8:17 ` [PATCH v9 10/15] tools: mkimage: pre-load: add support of ecdsa Philippe Reynes
2026-09-03 14:36 ` Raymond Mao
2026-09-03 8:17 ` [PATCH v9 11/15] tools: binman: " Philippe Reynes
2026-09-03 14:37 ` Raymond Mao
2026-09-03 8:17 ` [PATCH v9 12/15] boot: " Philippe Reynes
2026-09-03 14:38 ` Raymond Mao
2026-09-03 8:17 ` [PATCH v9 13/15] tools: preload_check_sign: " Philippe Reynes
2026-09-03 14:39 ` Raymond Mao
2026-09-03 8:17 ` [PATCH v9 14/15] test: py: vboot: prepare test for global signature with ecdsa Philippe Reynes
2026-09-03 14:40 ` Raymond Mao
2026-09-03 8:17 ` [PATCH v9 15/15] test: py: vboot: add " Philippe Reynes
2026-09-03 14:41 ` Raymond Mao
2026-09-03 18:35 ` [PATCH v9 00/15] add software ecdsa support Tom Rini
2026-09-04 8:10 ` Philippe Reynes
2026-09-04 14:32 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260903183323.GK1764417@bill-the-cat \
--to=trini@konsulko.com \
--cc=jonny.green@keytechinc.com \
--cc=marko.makela@iki.fi \
--cc=philippe.reynes@softathome.com \
--cc=raymondmaoca@gmail.com \
--cc=simon.glass@canonical.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.u-boot-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.