From: Mukul Joshi <mukul.joshi@amd.com>
To: <amd-gfx@lists.freedesktop.org>
Cc: <Harish.Kasiviswanathan@amd.com>, <felix.kuehling@amd.com>,
Mukul Joshi <mukul.joshi@amd.com>
Subject: [PATCH 2/2] drm/amdgpu: Reset UALink connection on failed TLB-shootdown send
Date: Thu, 3 Sep 2026 16:48:41 -0400 [thread overview]
Message-ID: <20260903204841.3485963-2-mukul.joshi@amd.com> (raw)
In-Reply-To: <20260903204841.3485963-1-mukul.joshi@amd.com>
If sending TLB shootdown to a remote GPU fails, reset the connection and
mark the connection as NOT_READY.
Signed-off-by: Mukul Joshi <mukul.joshi@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ualink.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ualink.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ualink.c
index f5865c5fe93e..5b3c7f62c34d 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ualink.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ualink.c
@@ -2681,10 +2681,19 @@ static void amdgpu_ualink_send_tlb_shootdown(struct amdgpu_device *adev,
r = amdgpu_ualink_remote_shootdown(adev, remote_acc_id,
npa_addr, size,
AMDGPU_UALINK_HEAVYWEIGHT_TLB_SHOOTDOWN);
- if (r)
+ if (r) {
dev_err(adev->dev,
"EXP-CLEANUP: TLB shootdown send failed to remote:%u\n",
remote_acc_id);
+
+ /* Send failed: mark the connection NOT_READY so the
+ * rest of this cleanup (and other cleanups) skip the
+ * unreachable peer via amdgpu_ualink_check_conn_ready().
+ */
+ amdgpu_ualink_handle_connection_reset(adev, remote_acc_id,
+ AMDGPU_UALINK_CONN_NOT_READY,
+ imp_entry->generation_count);
+ }
}
}
--
2.54.0
next prev parent reply other threads:[~2026-09-03 20:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 20:48 [PATCH 1/2] drm/amdgpu: Don't ignore LSDMA copy errors during remote interrupt send Mukul Joshi
2026-09-03 20:48 ` Mukul Joshi [this message]
2026-09-03 21:40 ` [PATCH 2/2] drm/amdgpu: Reset UALink connection on failed TLB-shootdown send Kasiviswanathan, Harish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260903204841.3485963-2-mukul.joshi@amd.com \
--to=mukul.joshi@amd.com \
--cc=Harish.Kasiviswanathan@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=felix.kuehling@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.