From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D7A2C624D6 for ; Thu, 3 Sep 2026 22:06:10 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x2FZ3-00072e-Rt; Thu, 03 Sep 2026 18:05:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x2FYy-000722-6n for qemu-devel@nongnu.org; Thu, 03 Sep 2026 18:05:40 -0400 Received: from smtp-out2.suse.de ([195.135.223.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1x2FYw-0003Xv-F9 for qemu-devel@nongnu.org; Thu, 03 Sep 2026 18:05:39 -0400 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7BCAF1FB72; Thu, 3 Sep 2026 22:05:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1788473132; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pRqBD/PHDASXS3lwKxlGehkJB1IW1YP1x7TTWwTOVik=; b=cYZjg8QjSy+djof7lRdOhAqxLNQ2f9fimehc2a51UlrcTjqePOYfFoM8tq02aSPh+JHXER z/He+dbbw2YhxlUTQQmQiU04rG53siK6TXp05WRFRS9aEMIKzRZCqn0fZoUnkyccQH1g/F lpCt1GbgDNpi7LptW1/RXfOrz190nzM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1788473132; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pRqBD/PHDASXS3lwKxlGehkJB1IW1YP1x7TTWwTOVik=; b=5VjqICQLZBNTggQvGxvsyYP4sOWCcG0kDeIKWRJgInTxgMklpzL3n5zmmPgMemX3TEHu9x SRlJjXioZuIM4oDA== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="PfBgtAS/"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ZtJKZB4c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1788473128; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pRqBD/PHDASXS3lwKxlGehkJB1IW1YP1x7TTWwTOVik=; b=PfBgtAS/FqogqjD5gjnl2eQ7jo9yqoFXjtYQg6LiXtC/Th+6wGpfoPJbQ+aD+6AFZwmeo8 sf3i78Ck3GQ3snsGSVGx93Zq6AJpXFVy30cwfb3SyW8N2Z9tBSAQ++eKBtoR3z8NUtDWlp RHQYB65xwL3JRjAcSNdPjRkOZynyQPw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1788473128; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pRqBD/PHDASXS3lwKxlGehkJB1IW1YP1x7TTWwTOVik=; b=ZtJKZB4cGp8ETKq+RtxJNKiBqMSsYwgdhWYsRW53wb41E4e02WNyFT6P5YukJXtJWGyTh2 m46kAIwZzfShweCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4FE2913736; Thu, 3 Sep 2026 22:05:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id +Jl5CCfvmWppUQAAD6G6ig (envelope-from ); Thu, 03 Sep 2026 22:05:27 +0000 From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: John Snow , "Denis V. Lunev" Subject: [PATCH 1/3] ahci: Fix leak of IRQState Date: Thu, 3 Sep 2026 19:05:21 -0300 Message-ID: <20260903220523.2849019-2-farosas@suse.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260903220523.2849019-1-farosas@suse.de> References: <20260903220523.2849019-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 7BCAF1FB72 X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Action: no action X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:dkim,suse.de:email,suse.de:mid]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[suse.de:+] Received-SPF: pass client-ip=195.135.223.131; envelope-from=farosas@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org ASAN spotted an indirect leak in ahci-test: Indirect leak of 576 byte(s) in 6 object(s) allocated from: #0 0x556112a08ca0 in malloc #1 0x7f21591e595d in g_malloc #2 0x7f21591ffe38 in g_slice_alloc #3 0x7f21591c988d in g_hash_table_new_full #4 0x556114d756f1 in object_initialize_with_type ../qom/object.c:506:23 #5 0x556114d77590 in object_new_with_type ../qom/object.c:706:5 #6 0x556114d777e8 in object_new ../qom/object.c:722:12 #7 0x556114d6d2be in qemu_allocate_irq ../hw/core/irq.c:94:25 #8 0x556114d6d1bc in qemu_extend_irqs ../hw/core/irq.c:82:16 #9 0x556114d6d329 in qemu_allocate_irqs ../hw/core/irq.c:89:12 #10 0x5561135da9bd in ahci_realize ../hw/ide/ahci.c:1644:12 #11 0x55611360156a in pci_ich9_ahci_realize ../hw/ide/ich.c:132:5 Although ahci_realize() frees the return of qemu_allocate_irqs() right away, the individual IRQStates are still left around. Issue qemu_free_irq() at ahci_uninit(). Signed-off-by: Fabiano Rosas --- hw/ide/ahci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 6b04762c4a..86f6297dc9 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -1688,6 +1688,7 @@ void ahci_uninit(AHCIState *s) } ide_exit(ide_state); } + qemu_free_irq(ad->port.irq); object_unparent(OBJECT(&ad->port)); } -- 2.53.0