All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Godana Emiru <godanaemiru@gmail.com>
Cc: parthiban.veerasooran@microchip.com,
	christian.gromm@microchip.com, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: most: video: document the locks in struct most_video_dev
Date: Thu, 3 Sep 2026 10:31:37 +0200	[thread overview]
Message-ID: <2026090351-trickily-churn-6635@gregkh> (raw)
In-Reply-To: <20260901172055.53889-1-godanaemiru@gmail.com>

On Tue, Sep 01, 2026 at 08:20:55PM +0300, Godana Emiru wrote:
> Neither lock in struct most_video_dev carries a comment describing what
> it protects.
> 
> list_lock protects the pending_mbos list. Buffers are added by the
> component's rx_completion callback, comp_rx_data(), which is invoked
> from the interface driver's completion path (a URB completion handler
> in the case of the USB HDM), and are removed from process context by
> comp_vdev_read() and comp_vdev_close(). Note that in the comment, since
> it is what makes the irq-safe spinlock variants necessary here.
> 
> lock is never acquired by this driver directly. comp_register_videodev()
> installs it as struct video_device::lock, where v4l2_ioctl_get_lock()
> returns it and video_ioctl2() holds it across ioctl dispatch.

What tool did you use to generate this changelog?

thanks,

greg k-h

  reply	other threads:[~2026-09-03  8:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-01 17:20 [PATCH] staging: most: video: document the locks in struct most_video_dev Godana Emiru
2026-09-03  8:31 ` Greg KH [this message]
2026-09-03 13:29   ` Godana Emiru
2026-09-07 16:15     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026090351-trickily-churn-6635@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=christian.gromm@microchip.com \
    --cc=godanaemiru@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=parthiban.veerasooran@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.