From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76911C79F82 for ; Fri, 4 Sep 2026 19:59:19 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x2a3q-0006Ps-Je; Fri, 04 Sep 2026 15:58:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x2a3m-0005tH-12 for qemu-devel@nongnu.org; Fri, 04 Sep 2026 15:58:50 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x2a3k-0007tE-II for qemu-devel@nongnu.org; Fri, 04 Sep 2026 15:58:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788551927; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7SMs4lAmkVoRXQNMq8ERRdBMSlVCwycR0HsXxzfGsJ4=; b=jCanim1ya9v8oM6y80//rUQG5qaBTeRN4jJRd+dexESBJjovCXGdAJEZdNsDpVycohSH3y i2ykRCJuC3ToXqT35ok50AgBs8ip7A6LVUPGufdZM6r4bfXJwGFG24pgil5PazAMIfyJzq hHR8ag4VjZQRaNZS/PCq/jQEiK403Ug= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-183-LkKaRcDqMOKMpfK9cseqJg-1; Fri, 04 Sep 2026 15:58:45 -0400 X-MC-Unique: LkKaRcDqMOKMpfK9cseqJg-1 X-Mimecast-MFC-AGG-ID: LkKaRcDqMOKMpfK9cseqJg_1788551924 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9D629188FEF6; Fri, 4 Sep 2026 19:58:44 +0000 (UTC) Received: from localhost (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A06681955F01; Fri, 4 Sep 2026 19:58:43 +0000 (UTC) From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Fri, 04 Sep 2026 23:57:53 +0400 Subject: [PATCH v4 10/75] qom/qmp: populate description & default-value in qom_property_info() MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20260904-qom-qapi-v4-10-a985f168e938@redhat.com> References: <20260904-qom-qapi-v4-0-a985f168e938@redhat.com> In-Reply-To: <20260904-qom-qapi-v4-0-a985f168e938@redhat.com> To: qemu-devel@nongnu.org Cc: Markus Armbruster , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Michael Roth , Pierrick Bouvier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Developer-Signature: v=1; a=openpgp-sha256; l=2391; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=8aX4sw0U6wmPskhkshFQH7h3T2tIQFeLMa3pE2ujfQw=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqmyLItjOGlRzimMqjEbdBy7HbatO5wMWlxtyuX lj7+XBsFPuJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCapsiyAAKCRDa6OEJdZac 5Xf/D/wKARWoR98eMak93C9HCQ48pXtTvYWjh8rvQkasElicd3TBa/5UVUSPaxjOX5QQ+eUKA/M NRy5eoydOnYtbO6v0mX4klcqzjn72pgUG7QevqyqktESYCcBU7awSgIx7MBbgvY2we5ZTfb1i3K u+E8yE6RqPYKHJwppY2k5OPKAnck1CrfarIxn+IrX8eBwGYgB5WhPoie+vy9nj3ccfPCySg0f8D lJVRRDHqO7kGHiXkn5JdgZu/4T32ZRujupydvbUlhY39GtjxzSNVLW6fr3Am7SR3ReHjPhoVkeT MWsMmtdhJzDhFcNbLo3mvLjDc3JWAJ/mrYfuCWbpMxIiXFOqEgG7n9x5pMXJqGxXDbamA3vOMno AMp7X4d8RXaGKnUffwGamG+N8vHAFmWlghpq+anNGrbCQ9W9tOqYKNhfUq3H2lnHmuLmg6R3GaR mHt+y+CUzvHdVajMDPXje56ha3J5lZ3iE81etFNTjum9wtq7DHmIBE3FxI+9URCh5QERjaeyFf9 9h0dEOowv/7mwWTxwckGX1wRrCyEIE3fF71XzyVGwxpU7UImUsw2mh5nJRWwxCZH2sU274F+s5L w+/8ZrTjgqxFgIPVwHrlFhiMuXzr7xV+XikEvPx10LNx3hh1XxJW2usUo0pVAY30A84FLeyGIEG 8/3J8qBAZY9oCDA== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Move description and default_value population from the individual QMP handlers into qom_property_info(), so all callers get them. This also adds description and default-value to qom-list responses, which previously only returned name and type. The handler doesn't care. Signed-off-by: Marc-André Lureau --- qom/qom-qmp-cmds.c | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/qom/qom-qmp-cmds.c b/qom/qom-qmp-cmds.c index f9e6d4371cc5..782a9af14de5 100644 --- a/qom/qom-qmp-cmds.c +++ b/qom/qom-qmp-cmds.c @@ -35,6 +35,8 @@ static ObjectPropertyInfo *qom_property_info(ObjectProperty *prop) info->name = g_strdup(prop->name); info->type = g_strdup(prop->type); + info->description = g_strdup(prop->description); + info->default_value = qobject_ref(prop->defval); if (prop->qapi_type) { info->qapi_type = g_strdup(prop->qapi_type->masked_name); } @@ -218,8 +220,6 @@ ObjectPropertyInfoList *qmp_device_list_properties(const char *typename, object_property_iter_init(&iter, obj); while ((prop = object_property_iter_next(&iter))) { - ObjectPropertyInfo *info; - /* Skip Object and DeviceState properties */ if (strcmp(prop->name, "type") == 0 || strcmp(prop->name, "realized") == 0 || @@ -229,11 +229,7 @@ ObjectPropertyInfoList *qmp_device_list_properties(const char *typename, continue; } - info = qom_property_info(prop); - info->description = g_strdup(prop->description); - info->default_value = qobject_ref(prop->defval); - - QAPI_LIST_PREPEND(prop_list, info); + QAPI_LIST_PREPEND(prop_list, qom_property_info(prop)); } object_unref(obj); @@ -270,12 +266,7 @@ ObjectPropertyInfoList *qmp_qom_list_properties(const char *typename, object_property_iter_init(&iter, obj); } while ((prop = object_property_iter_next(&iter))) { - ObjectPropertyInfo *info = qom_property_info(prop); - - info->description = g_strdup(prop->description); - info->default_value = qobject_ref(prop->defval); - - QAPI_LIST_PREPEND(prop_list, info); + QAPI_LIST_PREPEND(prop_list, qom_property_info(prop)); } object_unref(obj); -- 2.55.0.543.g5ebe2ebe4ea8