From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72344C624D3 for ; Fri, 4 Sep 2026 20:00:18 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1x2a4y-0001wR-6m; Fri, 04 Sep 2026 16:00:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x2a4u-0001oL-Rq for qemu-devel@nongnu.org; Fri, 04 Sep 2026 16:00:00 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1x2a4t-000810-8R for qemu-devel@nongnu.org; Fri, 04 Sep 2026 16:00:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788551998; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BgmINsOfsOg8avUK0DI3pyw4m6ampH+tq1kvfcER51g=; b=GWxX+N5ZYro6BuKZOhGnDhw/gmeUeBdXJvmRaXGRmgauiR4QMhGa/gGbH/EsG+8s3cyz90 Nyi32bwi3WboVEUcia0nXR/uIvzeMR2BcpcDiT3kzl6xJG8kyTAV1wl0i/BSjkJ0r0cxoR F9b4CqAvPIoKA6ymJ7LYVNMCSwJjC2I= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-509-pajKOWMCPGaYRg5wDocAkA-1; Fri, 04 Sep 2026 15:59:57 -0400 X-MC-Unique: pajKOWMCPGaYRg5wDocAkA-1 X-Mimecast-MFC-AGG-ID: pajKOWMCPGaYRg5wDocAkA_1788551996 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0E46E180A9F1; Fri, 4 Sep 2026 19:59:56 +0000 (UTC) Received: from localhost (headnet05.pony-001.prod.iad2.dc.redhat.com [10.2.32.117]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 41CD618005B5; Fri, 4 Sep 2026 19:59:54 +0000 (UTC) From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Fri, 04 Sep 2026 23:58:12 +0400 Subject: [PATCH v4 29/75] whpx: convert OnOffSplit property to QAPI-aware registration MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20260904-qom-qapi-v4-29-a985f168e938@redhat.com> References: <20260904-qom-qapi-v4-0-a985f168e938@redhat.com> In-Reply-To: <20260904-qom-qapi-v4-0-a985f168e938@redhat.com> To: qemu-devel@nongnu.org Cc: Markus Armbruster , Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Michael Roth , Pierrick Bouvier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Pedro Barbuda , Mohamed Mediouni X-Developer-Signature: v=1; a=openpgp-sha256; l=2351; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=65zE86SlpLyxllbMtWWTTzs6HGNGESGG/p9K0JvZjvc=; b=kA0DAAoB2ujhCXWWnOUByyZiAGqbIsmiw2lFCUUh7DQc6knBdr90jSFZOmj5Xe6uEVOkrgGUr IkCMwQAAQoAHRYhBIepvZM/h8YG0nb2Ldro4Ql1lpzlBQJqmyLJAAoJENro4Ql1lpzlL5wQAIYn FI0s46YWbxHZZuKnvrKbqfQiB1SjpMx1qqyezfrJjpVSYXvDXfdHWQwwFqUBsF5cZry15fIJo4c Uq1IDc1wQ84RkgZk4rgi44STrTQ5xn3hXAgmuEjbd5QBdABaEa8gVfn5L56avSL68RMdKxB5POp 2Aqn4vP56lwxVz1nbFHyoUOWImPL066b/gOg8oVVTjtJIB7PofDN489oN6XQ/jotZ2dR5m2bYGh pD/SasYI8g5QY9RlcPgSaDQD35agzxtPy1F866hsv7cnBKjG2ygEsHAFrAIas4POIlu7fY7BIJ/ DGJDbphie8rYcWCZ3aHP5a7YE+zV20/cSAiXOWfqi2Cweo4rNti2s1HkttJQy6k4ZjmMn0XUakn QSZso3FUVp66X7eKcPDWkVssv06r6R7HtiGOVvGr+LgWYhqT5km52WV7JPNduPHpqPHwYEUQv3z F41A/kVJta9sk/yizNFbyHANjNVmPCezHEiTiDOa220ynFqN0LfqYaR45H/5i+UwLgA32ODN5wx qFqxuqJmMkLvDAfctSh7/vjZAvRzT7v885Mn/DnMrnxn5bpkjr0bJp+PtmgjLzlHEjwqaz7p/xu CdSPhtHl7YwZY7djLqp1Ct5AxKcEdA8g/UOJpGH2FyqI2Mw+YiWttxkEmhYfsFb6oXFlHNqnXNm LF2u8 X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Convert the OnOffSplit property from manual visitor-based callbacks to property_add_qapi_enum(). Signed-off-by: Marc-André Lureau --- accel/whpx/whpx-common.c | 29 ++++++++++------------------- 1 file changed, 10 insertions(+), 19 deletions(-) diff --git a/accel/whpx/whpx-common.c b/accel/whpx/whpx-common.c index 187938c02b51..5d4b405e56d3 100644 --- a/accel/whpx/whpx-common.c +++ b/accel/whpx/whpx-common.c @@ -434,18 +434,12 @@ error: return false; } -static void whpx_set_kernel_irqchip(Object *obj, Visitor *v, - const char *name, void *opaque, - Error **errp) +static void whpx_set_kernel_irqchip(Object *obj, int value, + Error **errp) { struct whpx_state *whpx = &whpx_global; - OnOffSplit mode; - if (!visit_type_OnOffSplit(v, name, &mode, errp)) { - return; - } - - switch (mode) { + switch (value) { case ON_OFF_SPLIT_ON: whpx->kernel_irqchip_allowed = true; whpx->kernel_irqchip_required = true; @@ -463,11 +457,7 @@ static void whpx_set_kernel_irqchip(Object *obj, Visitor *v, break; default: - /* - * The value was checked in visit_type_OnOffSplit() above. If - * we get here, then something is wrong in QEMU. - */ - abort(); + g_assert_not_reached(); } } @@ -518,11 +508,12 @@ static void whpx_accel_class_init(ObjectClass *oc, const void *data) ac->pre_resume_vm = whpx_pre_resume_vm; ac->allowed = &whpx_allowed; - object_class_property_add(oc, "kernel-irqchip", "on|off|split", - NULL, whpx_set_kernel_irqchip, - NULL, NULL); - object_class_property_set_description(oc, "kernel-irqchip", - "Configure WHPX in-kernel irqchip"); + object_class_property_add_qapi_enum(oc, QAPI_ENUM_PROP( + .name = "kernel-irqchip", + .qapi_type = &OnOffSplit_type_info, + .set = whpx_set_kernel_irqchip, + .description = "Configure WHPX in-kernel irqchip", + )); object_class_property_add_qapi_enum(oc, QAPI_ENUM_PROP( .name = "hyperv", .description = "Configure Hyper-V enlightenments", -- 2.55.0.543.g5ebe2ebe4ea8