Re: [PATCH v4 17/17] KVM: selftests: Always assert that vmreadz() succeeds

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Typo in assertion message: 'vmwread' instead of 'vmread'.
--

commit b99bd290de04e34e69f57ca551e7c07af56c2b56
Author: Sean Christopherson <seanjc@google.com>

    KVM: selftests: Always assert that vmreadz() succeeds
    
    Rename vmreadz() => vmread() (and vmread() => __vmread()) and have it
    assert success instead of returning garbage on failure.  While the eVMCS
    path avoids clobbering *value on failure, the VMREAD path unconditionally
    stores tmp to *value, without ever zeroing tmp.

> diff --git a/tools/testing/selftests/kvm/include/x86/vmx.h b/tools/testing/selftests/kvm/include/x86/vmx.h
> index be10028c51b96..a4807e41fe69c 100644
> --- a/tools/testing/selftests/kvm/include/x86/vmx.h
> +++ b/tools/testing/selftests/kvm/include/x86/vmx.h
[ ... ]
> @@ -399,18 +399,17 @@ static inline int vmread(u64 encoding, u64 *value)
>  		: [encoding]"r"(encoding)
>  		: "cc", "memory");
>  
> -	*value = tmp;
> +	if (!ret)
> +		*value = tmp;
>  	return ret;
>  }
>  
> -/*
> - * A wrapper around vmread that ignores errors and returns zero if the
> - * vmread instruction fails.
> - */
> -static inline u64 vmreadz(u64 encoding)
> +static inline u64 vmread(u64 encoding)
>  {
>  	u64 value = 0;
> -	vmread(encoding, &value);
> +
> +	__GUEST_ASSERT(!__vmread(encoding, &value),
> +		       "vmwread[0x%lx] hit VM-Fail", encoding);

[Severity: Low]
Is there a typo in the assert message here? It says 'vmwread' instead of
'vmread'.

>  	return value;
>  }
>

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260904002423.3154436-1-seanjc@google.com?part=17