From: sashiko-bot@kernel.org
To: "Priyank Rathod" <rathodpriyank@google.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH v3 2/3] PCI/ASPM: Add pci_aspm_inhibit() helper for temporary link state suppression
Date: Fri, 04 Sep 2026 05:31:39 +0000 [thread overview]
Message-ID: <20260904053139.AD9D91F00A3E@smtp.kernel.org> (raw)
In-Reply-To: <20260904-pcie-link-endpoints-v3-2-4b9a91bd4b35@google.com>
> Currently, pci_disable_link_state() permanently disables ASPM on a PCIe
> link by setting link->aspm_disable. However, several kernel subsystems
> and driver operations require temporary ASPM inhibition without
> permanently disabling power management:
> - PCIe Lane Margining at Receiver (LMR): receiver testing requires
> the link to remain continuously in L0 throughout the test duration.
> - Device firmware updates (e.g. NICs and NVMe controllers): link
> latency or L1 transitions during firmware flashing can disrupt
> device communication.
> - Secondary Bus Reset and link retraining sequences: prevent
> unexpected L1/L1SS entry during link reset and recovery.
>
> Because pci_disable_link_state() cannot be reversed by
> pci_enable_link_state() to clear link->aspm_disable, drivers previously
> attempted manual manipulations of PCI_EXP_LNKCTL (ASPMC). This
> [ ... ]
> - When all inhibitors have released (aspm_inhibit_cnt == 0), restores
> the configured ASPM policy to hardware (Upstream Component before
> Downstream Component per sec 7.5.3.7 & Table 7-24).
>
> Signed-off-by: Priyank Rathod <rathodpriyank@google.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260904-pcie-link-endpoints-v3-0-4b9a91bd4b35@google.com?part=2
next prev parent reply other threads:[~2026-09-04 5:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 5:24 [PATCH v3 0/3] PCI/pcie: Add PCIe Lane Margining at Receiver (LMR) support Priyank Rathod
2026-09-04 5:24 ` [PATCH v3 1/3] PCI: Add pcie_get_link_endpoints() helper Priyank Rathod
2026-09-04 5:32 ` sashiko-bot
2026-09-04 5:24 ` [PATCH v3 2/3] PCI/ASPM: Add pci_aspm_inhibit() helper for temporary link state suppression Priyank Rathod
2026-09-04 5:31 ` sashiko-bot [this message]
2026-09-04 5:24 ` [PATCH v3 3/3] PCI/pcie: Add PCIe Lane Margining at Receiver (LMR) support Priyank Rathod
2026-09-04 5:31 ` sashiko-bot
2026-09-18 17:02 ` [PATCH v3 0/3] " Priyank Rathod
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260904053139.AD9D91F00A3E@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rathodpriyank@google.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.