Re: [LTP] cpuset_memory_spread: make result_check() robust to page-cache noise

[linuxtestproject.agent@gmail.com]

Hi Changwei,

On Fri, Sep 4, 2026, Changwei Zou wrote:
> cpuset_memory_spread: make result_check() robust to page-cache noise

> +	# when min_upper / max_lower (floating) is not less than
> +	# upperlimit / lowerlimit, the test passes.
> +	if awk -v mu="$min_upper" -v xl="$max_lower" \
> +	       -v ul="$upperlimit" -v ll="$lowerlimit" \
> +	       'BEGIN {
> +	                if (xl == 0) { exit !(mu > 0) }
> +	                exit !((mu / xl) >= (ul / ll))
> +	        }'; then

This ratio can accept genuine unexpected-node allocations when unrelated
activity inflates an expected node. With 4 KiB pages, 500000/100000 passes;
with 64 KiB pages, even 20000/60000 passes because 10000/32768 is below one.
Retain an absolute cap for max_lower or isolate the test file's cache pages.

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp