From: sashiko-bot@kernel.org
To: "Jinjie Ruan" <ruanjinjie@huawei.com>
Cc: tytso@mit.edu, linux-ext4@vger.kernel.org
Subject: Re: [PATCH v4 2/2] ext4: Convert group-count barrier protocol to acquire/release
Date: Fri, 04 Sep 2026 07:40:50 +0000 [thread overview]
Message-ID: <20260904074050.EEA7B1F00A3D@smtp.kernel.org> (raw)
In-Reply-To: <20260904073253.663243-3-ruanjinjie@huawei.com>
> During an online resize, reading s_groups_count and s_blockfile_groups
> requires strict ordering against subsequent initialized block group
> metadata.
>
> Replace the historical smp_wmb()/smp_rmb() pairs with smp_store_release()
> and smp_load_acquire(). This formalizes the publish-subscribe pattern
> and allows weakly-ordered architectures (e.g., arm64) to utilize native
> STLR/LDAR instructions instead of full DMB fences.
>
> Update the documentation in resize.c and ext4.h accordingly.
>
> Assisted-by: Gemini:Gemini-3.1
> Assisted-by: DeepSeek:DeepSeek-V3
> Reviewed-by: Zhang Yi <yi.zhang@huawei.com>
> Reviewed-by: Jan Kara <jack@suse.cz>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260904073253.663243-1-ruanjinjie@huawei.com?part=2
prev parent reply other threads:[~2026-09-04 7:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 7:32 [PATCH v4 0/2] ext4: Convert group-count barrier protocol to acquire/release Jinjie Ruan
2026-09-04 7:32 ` [PATCH v4 1/2] ext4: Fix out-of-bounds read in ext4_get_group_info() Jinjie Ruan
2026-09-04 7:47 ` sashiko-bot
2026-09-04 7:32 ` [PATCH v4 2/2] ext4: Convert group-count barrier protocol to acquire/release Jinjie Ruan
2026-09-04 7:40 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260904074050.EEA7B1F00A3D@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=ruanjinjie@huawei.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.