Re: [PATCH v5 1/4] iio: ABI: Add DAC current powerdown attributes and 15kohm_to_gnd mode

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch documents out_currentY_powerdown_mode but misses the corresponding _available attributes.
--

commit 8792fdce55087374092373b1e07164bea5a13f94
Author: Kim Seer Paller <kimseer.paller@analog.com>

iio: ABI: Add DAC current powerdown attributes and 15kohm_to_gnd mode

This commit documents the out_currentY_powerdown and
out_currentY_powerdown_mode attributes for current-output DAC channels.
It also adds the 15kohm_to_gnd powerdown mode to the list of available
modes.

> diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
> index a4f5595722ade..a0f9aada5c62d 100644
> --- a/Documentation/ABI/testing/sysfs-bus-iio
> +++ b/Documentation/ABI/testing/sysfs-bus-iio
> @@ -762,6 +762,8 @@ What:		/sys/bus/iio/devices/iio:deviceX/out_voltageY_powerdown_mode
>  What:		/sys/bus/iio/devices/iio:deviceX/out_voltage_powerdown_mode
>  What:		/sys/bus/iio/devices/iio:deviceX/out_altvoltageY_powerdown_mode
>  What:		/sys/bus/iio/devices/iio:deviceX/out_altvoltage_powerdown_mode
> +What:		/sys/bus/iio/devices/iio:deviceX/out_currentY_powerdown_mode
> +What:		/sys/bus/iio/devices/iio:deviceX/out_current_powerdown_mode

[Severity: Low]
Should the corresponding out_currentY_powerdown_mode_available and
out_current_powerdown_mode_available attributes be documented as well?

The existing voltage powerdown modes document their available variants
further down in Documentation/ABI/testing/sysfs-bus-iio:

What:           /sys/.../iio:deviceX/out_voltageY_powerdown_mode_available
What:           /sys/.../iio:deviceX/out_voltage_powerdown_mode_available
What:           /sys/.../iio:deviceX/out_altvoltageY_powerdown_mode_available
What:           /sys/.../iio:deviceX/out_altvoltage_powerdown_mode_available

It seems the current equivalents were omitted from this patch.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260904-iio-ad5710r-upstream-v5-0-76f985b7d0ee@analog.com?part=1