From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C78E451992 for ; Fri, 4 Sep 2026 10:29:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788517789; cv=none; b=QHDiTx58ca5+6CnZIXnYOBoJkNBIBxsI0pVE6YTZjhmOKiKUE8ifcEcLE9tb4lHXoJciOZp3kzAIzivxxAZ6izH2v+mJaHpJmLx9F5gTJpOWOPl5D97ZpkYUJkyE0FpOY9vXf79rm1WwOu54eAWFvQnySrhGaYayboMGn8mLRDo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788517789; c=relaxed/simple; bh=eeHXegopGSO9TrtDqRq0OWQ3UTYXdSbvNnRvR81+LlA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Dv70aVJYkVNTxirEJyI79gwWcwjY74a7LR8U4MhL0XfW9WxIX1ss+AiZrF6mSU/i+EOlYHPEeWi61VtyIOp1PEvToVW/dZOiQP5uRfTOajxsbVYek/HO9CDrB6OPdiT3MLj+TZCGozC9jWhAlWoSlBMYSC5fQi/tYO4IOW/Kyoc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZwMc6wID; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZwMc6wID" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 690BD1F00A3D; Fri, 4 Sep 2026 10:29:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788517787; bh=UOp86vyMyz8ax7MOS7YPHkcLRYCSUPy0j+zkx8h4GYo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ZwMc6wIDJ/vsTUdxd13iyA+kRhPLcvdAN2AoieqEarOFxlfKbonBmJjqDHh8tUQhx YFYawm0XYXfdZWtd5zctNJaM97K30StB6KcRM5i9HmxQfhU+h2rVh9idiALBZxUSkf TiEkUSIiJxYgWjmEoJByMqKr1PmPBv9IFnVDIy7U1Uy7Dn6APM+L9ohOx27/CzA2e6 ZOaLXWtSUO4pJb4x8ssrsFfj4Qr/lG/xZgPO/RpAeSi+BAhOe26jh9TB00JkCGXO54 dLtIi6ur2R8dS8vrZhPjVJt5Q+XHtc6QSfZuJKhadfMaaPt84yVYX50tB32X4eV04W 5m4x0CLJbg5Rw== From: Sasha Levin To: stable@vger.kernel.org Cc: Hyunwoo Kim , John Johansen , Sasha Levin Subject: [PATCH 6.6.y] apparmor: fix out-of-bounds write when null terminating a label vec Date: Fri, 4 Sep 2026 06:29:45 -0400 Message-ID: <20260904102945.2499120-1-sashal@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <2026090321-librarian-canopy-80fd@gregkh> References: <2026090321-librarian-canopy-80fd@gregkh> Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Hyunwoo Kim [ Upstream commit 9f1e40193eef7f047e6b77cfb4b4cafdecd7a123 ] aa_vec_unique() null terminates at vec[n - dups] when VEC_FLAG_TERMINATE is passed. If the components are all distinct no duplicates are dropped, dups is 0 and the terminator goes to vec[n], so the caller has to provide room for n + 1 entries. aa_label_strn_parse() sets up its vector with vec_setup(profile, vec, len, gfp) and then calls aa_vec_unique(vec, len, VEC_FLAG_TERMINATE), but vec_setup() does not reserve the terminator entry. Up to LOCAL_VEC_ENTRIES it uses the local array of LOCAL_VEC_ENTRIES pointers, above that it allocates exactly len pointers. The terminator therefore lands one entry past the end of the local array when len is LOCAL_VEC_ENTRIES, and one entry past the end of the allocation when len is larger. len comes from the number of "//&" separated components in the label name and label_count_strn_entries() does not bound it. An unprivileged task reaches the parse by writing to /proc/self/attr/apparmor/current or through lsm_set_self_attr(2), both of which go through do_setattr(), and the name is parsed before the change_profile permission is checked. The query_label() path behind the securityfs .access file, which is mode 0666, performs no permission check at all. Every component has to resolve to a loaded profile, so a system with policy loaded is required. The other two VEC_FLAG_TERMINATE users work on a label vec that aa_label_alloc() has already sized with "+ 1 for null terminator entry on vec". Reserve the same entry in vec_setup() and DEFINE_VEC(). Passing len + 1 from the caller instead would move len == LOCAL_VEC_ENTRIES out of the local array and into kzalloc(). Fixes: f1bd904175e8 ("apparmor: add the base fns() for domain labels") Cc: stable@vger.kernel.org Signed-off-by: Hyunwoo Kim Signed-off-by: John Johansen [ replaced unavailable kzalloc_objs() with equivalent kcalloc() allocation ] Signed-off-by: Sasha Levin --- security/apparmor/include/label.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/security/apparmor/include/label.h b/security/apparmor/include/label.h index 5aca0f612f8fd..55b5372ecf240 100644 --- a/security/apparmor/include/label.h +++ b/security/apparmor/include/label.h @@ -22,7 +22,7 @@ struct aa_ns; #define LOCAL_VEC_ENTRIES 8 #define DEFINE_VEC(T, V) \ - struct aa_ ## T *(_ ## V ## _localtmp)[LOCAL_VEC_ENTRIES]; \ + struct aa_ ## T *(_ ## V ## _localtmp)[LOCAL_VEC_ENTRIES + 1]; \ struct aa_ ## T **(V) #define vec_setup(T, V, N, GFP) \ @@ -30,10 +30,10 @@ struct aa_ns; if ((N) <= LOCAL_VEC_ENTRIES) { \ typeof(N) i; \ (V) = (_ ## V ## _localtmp); \ - for (i = 0; i < (N); i++) \ + for (i = 0; i <= (N); i++) \ (V)[i] = NULL; \ } else \ - (V) = kzalloc(sizeof(struct aa_ ## T *) * (N), (GFP)); \ + (V) = kcalloc((N) + 1, sizeof(struct aa_ ## T *), (GFP)); \ (V) ? 0 : -ENOMEM; \ }) -- 2.53.0