Re: [PATCH v3 1/6] ASoC: dt-bindings: es8316: Document jack detect inversion

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added property `everest,jack-detect-inverted` is not restricted to `everest,es8316`, allowing invalid configurations for `everest,es8311` and `everest,es8323` to silently bypass schema validation.
--

commit 9fc0fc78c1e3b0ad9527382c3b761e13ee89bf26
Author: Hongyang Zhao <hongyang.zhao@thundersoft.com>
Subject: ASoC: dt-bindings: es8316: Document jack detect inversion

This commit documents the everest,jack-detect-inverted property to allow
boards to describe the jack-detect polarity used by their wiring for the
ES8316 driver without failing schema validation.

> diff --git a/Documentation/devicetree/bindings/sound/everest,es8316.yaml b/Documentation/devicetree/bindings/sound/everest,es8316.yaml
> index f4ff23120c5b5..9060358a9080c 100644
> --- a/Documentation/devicetree/bindings/sound/everest,es8316.yaml
> +++ b/Documentation/devicetree/bindings/sound/everest,es8316.yaml
> @@ -84,6 +84,11 @@ properties:
>    "#sound-dai-cells":
>      const: 0
>  
> +  everest,jack-detect-inverted:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description:
> +      Defined to invert the jack detection.
> +

[Severity: Low]
Since this property in Documentation/devicetree/bindings/sound/everest,es8316.yaml
is specifically for the ES8316, does it need to be restricted in the
existing allOf conditional block?

Currently, the schema uses an if block to disable ES8316-only supplies for
other codecs like ES8311 and ES8323:

allOf:
  - if:
      properties:
        compatible:
          not:
            contains:
              const: everest,es8316
    then:
      properties:
        avdd-supply: false
        cpvdd-supply: false
        dvdd-supply: false
        pvdd-supply: false

Without adding everest,jack-detect-inverted: false to this block, won't
invalid configurations using this property on ES8311 or ES8323 devices
silently pass schema validation?

>  required:
>    - compatible
>    - reg

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260904-rubikpi-next-20260605-v3-0-f49146d85af3@thundersoft.com?part=1