From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Pierrick Bouvier" <pierrick.bouvier@oss.qualcomm.com>,
devel@lists.libvirt.org,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Zhuoying Cai" <zycai@linux.ibm.com>
Subject: [PULL 03/13] crypto/x509-utils: propagate the error
Date: Fri, 4 Sep 2026 11:59:19 +0100 [thread overview]
Message-ID: <20260904105929.3450663-4-berrange@redhat.com> (raw)
In-Reply-To: <20260904105929.3450663-1-berrange@redhat.com>
From: Marc-André Lureau <marcandre.lureau@redhat.com>
Propagate the error when qcrypto_x509_get_pk_algorithm fails, instead of
falling through to return 0 (success) with *errp set.
Fixes: e8317c4c9f68 ("crypto/x509-utils: Add helper functions for DIAG 320 subcode 2")
Reviewed-by: Zhuoying Cai <zycai@linux.ibm.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
crypto/x509-utils.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/crypto/x509-utils.c b/crypto/x509-utils.c
index 34cbfca26b..edcc44de80 100644
--- a/crypto/x509-utils.c
+++ b/crypto/x509-utils.c
@@ -319,6 +319,9 @@ int qcrypto_x509_check_ecc_curve_p521(uint8_t *cert, size_t size, Error **errp)
int curve_id;
algo = qcrypto_x509_get_pk_algorithm(cert, size, errp);
+ if (algo < 0) {
+ return -1;
+ }
if (algo != GNUTLS_PK_ECDSA) {
return 0;
}
--
2.55.0
next prev parent reply other threads:[~2026-09-04 11:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 10:59 [PULL 00/13] Misc fixes patches Daniel P. Berrangé
2026-09-04 10:59 ` [PULL 01/13] crypto: Use g_autofree Daniel P. Berrangé
2026-09-04 10:59 ` [PULL 02/13] crypto/x509-utils: don't double set errp Daniel P. Berrangé
2026-09-04 10:59 ` Daniel P. Berrangé [this message]
2026-09-04 10:59 ` [PULL 04/13] io/channel-socket: do not treat a zero length write as an error Daniel P. Berrangé
2026-09-04 10:59 ` [PULL 05/13] io/channel-websock: send an HTTP 400 when the greeting has no space Daniel P. Berrangé
2026-09-04 10:59 ` [PULL 06/13] io/channel-websock: handle a blocked write during the handshake Daniel P. Berrangé
2026-09-04 10:59 ` [PULL 07/13] tests/unit: add websock handshake test Daniel P. Berrangé
2026-09-04 10:59 ` [PULL 08/13] io/channel-websock: do not lose QIO_CHANNEL_ERR_BLOCK while reading Daniel P. Berrangé
2026-09-04 10:59 ` [PULL 09/13] tests/unit: cover blocked IO during the websock handshake Daniel P. Berrangé
2026-09-04 10:59 ` [PULL 10/13] crypto: deprecate the AF_ALG crypto backend Daniel P. Berrangé
2026-09-04 10:59 ` [PULL 11/13] gitlab: use --emacs --quiet for checkpatch.pl instead of --terse Daniel P. Berrangé
2026-09-04 10:59 ` [PULL 12/13] configure: correctly honour --disable-containers Daniel P. Berrangé
2026-09-04 10:59 ` [PULL 13/13] docs/system/security: exclude uninitialized stack variables as bugs Daniel P. Berrangé
2026-09-04 12:19 ` [PULL 00/13] Misc fixes patches Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260904105929.3450663-4-berrange@redhat.com \
--to=berrange@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=devel@lists.libvirt.org \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pierrick.bouvier@oss.qualcomm.com \
--cc=qemu-devel@nongnu.org \
--cc=zycai@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.